Closed Bug 127476 Opened 23 years ago Closed 22 years ago

Non-ASCII characters in Imported IE Favorites are displayed as garbage

Categories

(SeaMonkey :: Bookmarks & History, defect, P2)

Product:
SeaMonkey
Component:
Bookmarks & History
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: kazhik, Assigned: bugs)

References

Details

(Keywords: dataloss, intl, Whiteboard: [adt1][Branch ETA: 04/29/01][m5+])

Attachments

(4 files, 1 obsolete file)

Screen shot with garbled bookmarks on WinXP-SC.
180.92 KB, image/jpeg
Details
screen shot on IE
180.92 KB, image/jpeg
Details
test cases for english window users
852 bytes, text/html
Details
final patch
1.78 KB, patch
ftang
: review+
ftang
: superreview+
dbaron
: approval+
Details | Diff | Splinter Review 
Non-ASCII characters in Imported IE Favorites are displayed as garbage.

Bookmarks menu has two "Imported IE Favorites". The one is links to
Windows folders, and the second is really imported bookmarks.
The latter has this bug.

Screenshot:
http://bugzilla.mozilla.gr.jp/showattachment.cgi?attach_id=578

Original report in Bugzilla-jp:
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=1927
Status: NEW → ASSIGNED
Keywords: nsbeta1
Priority: -- → P2
Target Milestone: --- → mozilla1.0
nsbeta1+ per Nav triage team
Keywords: nsbeta1 → nsbeta1+
Blocks: 120814
Whiteboard: [adt1]
cc'ing iqa, l10n and i18n folks.
>Bookmarks menu has two "Imported IE Favorites". 
why I only see one in my WinXP CN?
But the one I have show all % encoded without the real text.
Keywords: intl
Severity: normal → critical
Keywords: dataloss
> >Bookmarks menu has two "Imported IE Favorites". 
> why I only see one in my WinXP CN?
> But the one I have show all % encoded without the real text.

I have seen two menus, but when I create a new profile, then I saw only one.  I
don't what's the reason cause that through.

I have filed a bug 131811 for that, it marked a dup of bug 130079 which may
probably will be check in soon. (not sure if it can be checked-in branch)
More info.:
If with only one menu "Imported IE Favorites", it will show the problem in bug
131811. (same as Frank's problem) - display as % escaped instead of real text.
Once for some reasons, there are two "Imported IE Favorites" appear, items under
one of them will has the problem here. - display garbled.
ben- any progress on this ?
the patch in bug 130079 imply there are some difference between ASCII and
non-ASCII importing. Why ? Is that related to this bug ?
hmm.. if related to bug 130079 then i'd expect to see %xx encoded non-ASCII
chars, not garbage as we are seeing here.  however, i'm not really familiar with
the manner in which imported bookmarks are handled.
The patch for bug 130079 is now in both on trunk and branch, kazhik could you
try again and see if this is still valid?
This bug isn't fixed in 2002041503-trunk/WinXP.

darin, what would happen if we unescape all chars? 
andreas: the problem with unescaping non-ASCII chars is that we don't know what
charset they belong to.  hence, we have no way of knowing how to render the
resulting text.  this bug doesn't seem to be caused by not unescaping... instead
we have a bunch of non-ASCII characters showing up under the wrong charset.  so,
i don't see how unescaping could help even if we knew the charset :-/
Is it just the display that's messed up, or do the bookmarks themselves actually
not work, too?
Whiteboard: [adt1] → [adt1][ETA: 04/19/02]
The bookmarks are working however the contains looks like wrong, e.g. if I have
a Hotmail-Japan in JA IE / JA windows, when I click the garbled bookmark in
Netscape, it will go to English hotmail page not Japanese one.
Whiteboard: [adt1][ETA: 04/19/02] → [adt1][ETA: 04/19/02] [m5+]
iqa, please attach screen shot from both IE and Mozilla 
The Folder will display OK but bookmarks are garbled.
I saw same problem on WinME-JA.

I don't have a reproduce steps for the garbled bookmarks, but once there are 2
Imported IE Favorites appear, then one of them will has this garbled problem.

And I don't see this when I create a new profile, but the non-ascii characters
are escaped.
iqa, please attach screen shot from both IE and Mozilla 
>andreas: the problem with unescaping non-ASCII chars is that we don't know what
charset they belong to.
It looks like we know the URL is in a file url. We can assume it is the one
nsIPlatformCharset return. 
Suggest fix:
1. look at The patch for bug 130079. instead of unescaped for only ascii and
   a. unescaped everything, not only ascii
   b. the BookmarkParser::DecodeBuffer can convert the unescaped bytes into nsString
Attached image screen shot on IE — 
On same WinXp-SimpChinese system.
*** Bug 131811 has been marked as a duplicate of this bug. ***
*** Bug 138331 has been marked as a duplicate of this bug. ***
*** Bug 138379 has been marked as a duplicate of this bug. ***
Attached patch proposed patch (obsolete) — — Splinter Review 
try as I might, I can't get a test case for this, so could someone who can try
this patch and let me know if it works?
ben: if you need test cases, you should ask for it. It is very easy for us to
create test cases that you can test on your English machine to show the same
problem. If you don't ask, we won't know if you have problem to get it.
Comment on attachment 79974 [details] [diff] [review]
proposed patch

I test this on my Japanese WinNT. only one problem. you forgot to remove the
"." of the ".url"
so it should be 
+      nsAutoString name(Substring(bookmarkName, 0, 
+				   bookmarkName.Length() -
extension.Length()-1));

instead

change that and then
Attachment #79974 - Flags: review+
(continue from the last comment)
add the "-1" and then r=ftang
Attached patch final patch — — Splinter Review 
Thanks for the test case, Frank. I tested it myself using your test case and I
see the correct trademark symbol.
Attachment #79974 - Attachment is obsolete: true
sr=hyatt via IRC. Checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
*** Bug 122816 has been marked as a duplicate of this bug. ***
*** Bug 138359 has been marked as a duplicate of this bug. ***
*** Bug 139463 has been marked as a duplicate of this bug. ***
have this been land into branch yet ?

Could someone verify this on the trunk so we can ask for branch check in?
This was worked fine on 04-23 trunk build.
If this is fixed on the trunk, pls mark as Verified.

adt1.0.0 (on ADT's behalf) approval for checkin to the 1.0 branch. Pls check
this in today, then add the fixed1.0.0 keyword.
Keywords: adt1.0.0+
I still can't see bookmarks names in Imported IE favorites in Russian with
2002042403.
Russian letters replaced with %xx codes. 
BTW russian folder names in Imported IE favorites are OK.
So it is early to close this bug.
> I still can't see bookmarks names in Imported IE favorites in Russian 
> with 2002042403.

Are you using trunk or branch (RC1) build? can you check in latest trunk build
with a new profile?
I confirm this bug with trunc (0.9.9+ 2002042412) and RC1 2002042408 after removing
\Documnets and Settings\user\Application data\Mozilla\Profiles and registry.dat.
Sorry.
Andrew V. Samoilov:
We haven't checked into RC1 build.  The fix only can be seen in trunk build.

Can you try one more time with the steps:
1. Run Profile manager.
2. Create a NEW profile.
3. Launch browser.
Then see if you can see the bookmarks display properly?  Thanks!

Andrew, i did some more testing with the new trunk build (2002-04-26-08). On the
English Win2k here is what happens:
- add some russian bookmarks into IE Favorites;
- run trunk build with a new profile, look under IE Favorites;
the problem you reported (display of cyrillic chars as escaped chars is not
present in the trunk build on EN OS, because of what appears to be another bug:
mozilla doesn't display bookmarks in charset different from the system..) I can
see only the bookmarks that use Latin-1 charset ( no cyrillic, no japanese).I'll
file a new bug on that.
My question to you is: what system are you on? if you're on russian windows i
believe you wouldn't hit this bug and the display should be fine (follow the
steps above)
Keywords: approval
Whiteboard: [adt1][ETA: 04/19/02] [m5+] → [adt1][ETA: 04/19/02] [m5+] [Need a=]
Comment on attachment 80150 [details] [diff] [review]
final patch

r=ftang, carry the sr=hyatt @ IRC
Attachment #80150 - Flags: superreview+
Attachment #80150 - Flags: review+
Comment on attachment 80150 [details] [diff] [review]
final patch

a=dbaron for 1.0 branch checkin
Attachment #80150 - Flags: approval+
To Yuying Long 2002-04-26 10:33:

I can do it in Monday only. And I cannot download any new versions this month.
Sorry.

To marina@netscape.com 2002-04-26 11:15:

I am using English Win2k with Russian set as default locale.

Thanks!
pulling a branch tree...
Whiteboard: [adt1][ETA: 04/19/02] [m5+] [Need a=] → [adt1][Branch ETA: 04/29/01][m5+]
So, should I be able to see the fix in RC1 or not? Right now, RC1 on win98
Hebrew, Fresh profile, imported Hebrew favorites from IE display as %fa%e6%e5
etc. Hebrew folder names came thrugh ok thugh.
OS: Windows XP → All
To Yuying Long 2002-04-26 10:33 -------

I really can see Russian letter in 0.9.9+ 20020424 after creating new profile,
but rc-1 2002042412 is still broken.  Creating new profile is not an easiest
way for me because of some existed mail accounts.

Some unrelated remarks:

1. Setup program prints 1.0.0.2002042412 for 0.9.9+ trunk.
2. Help | Help Contents | Managing Profiles refers to Netscape 6 instead of
Mozilla (for Windows users).
3. It seems there is an odd "share" word in the first paragraph:
"Similarly, family members may want to share __share__ a copy of the same
browser software but keep their Internet identities separate."

Thanks.

You don't need to create a new profile to re-import IE favorites, you can delete
the IE Favorites folder, and then edit your prefs.js file and remove the
browser.bookmarks.added_static_root pref. This should force a re-import that
executes the new code. 
ADT sez they want this on the branch by 3PM today, and Ben has had time for only
a few hour sleep, so I asked Jag to try to check it in.
I did check this in on the branch. I swear I entered that as a comment, but
maybe I hadn't logged in or something. 
It is visible on bonsai that you checked it in on the branch.
Yep, I just came to the same conclusion. Adding fixed1.0.0 keyword.
Keywords: fixed1.0.0
I can not reproduce this on 04-29 branch build / WinXP-SimpChinese with a new
profile.
*** Bug 143625 has been marked as a duplicate of this bug. ***
*** Bug 143691 has been marked as a duplicate of this bug. ***
rs vrfy.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: