127490 - nsSchemaLoader::ProcessFacet may call SetFacetType on uninitialized PRUInt16

Status: VERIFIED FIXED

(Core :: XML, defect, P5)

Description

[Aleksey Nogin]

Compiler warning:

extensions/xmlextras/schema/src/nsSchemaLoader.cpp:2672
 `PRUint16 facetType' might be used uninitialized in this function

See
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/xmlextras/schema/src/nsSchemaLoader.cpp&mark=2672,2709#2657

If nsSchemaLoader::ProcessFacet is passed an uncecognized aTagName, none of the
if branches will be taken and facetInst->SetFacetType will be passed an
uninitalized facetType.

Comment 1

[Aleksey Nogin]

Bug 59652 is the tracking bug for "xxx might be used uninitialized" warnings.

Comment 2

[Peter Van der Beken [:peterv]]

*** Bug 131347 has been marked as a duplicate of this bug. ***

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Proposed fix

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Er, bail out if we can't handle it is better

I need to wake up. More coffee.

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Vidur, can you review?

Comment 6

[John Bandhauer]

Comment on attachment 74998 [details] [diff] [review]
Er, bail out if we can't handle it is better

sr=jband. returning an error seems correct. OK with me if reviewers like it.

Comment 7

[vidur (gone)]

Comment on attachment 74998 [details] [diff] [review]
Er, bail out if we can't handle it is better

r=vidur. Failure seems reasonable since we shouldn't expect to hit this case
(maybe return NS_ERROR_UNEXPECTED?).

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: return unexpected

Hmm, makes sense. Will return NS_ERROR_UNEXPECTED.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 75478 [details] [diff] [review]
return unexpected

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 10

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Checked in.

Comment 11

[Aleksey Nogin]

This warning no longer listed on TBox -
http://tinderbox.mozilla.org/SeaMonkey/warn1016784600.2968.html (Fri, 22 Mar
2002 03:10 EST), marking VERIFIED