128503 - quicksearch field behavior in AB window not consistent with mail 3pane window

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[sairuh (rarely reading bugmail)]

the behavior of the quicksearch field in the addressbook window differs from the
behavior in the mail 3pane window. tested using 2002.03.01.08 comm bits on linux
rh7.2.

in the mail 3pane, i see the following when using quicksearch:

a. clicking in the field selects the text (if there's a string there already),
usually, but also see bug 126314 for issues there.
b. after typing, then pausing for a bit, the string in the field becomes
highlighted (due to search completing) --see bug 128500 for issues with that.
c. hitting enter after typing a string will select the string.

in comparison, the addressbook window exhibits the following with quicksearch:

a. clicking in the field containing a string only places the cursor --no selection.
b. there is no selection when pausing while typing or after the search is done.
c. there is no selection when hitting enter after typing a string.

Comment 1

[Navin Gupta]

reassigning to component owner. 

Comment 2

[David :Bienvenu]

I *think* Seth might have done this.

Comment 3

[Ninoschka Baca]

Trunk build 2002-03-07: WinMe
Reproduced on windows as well.

Adding nsbeta1 to consider for usability reasons. After a search you can tab to
the desired card but after pressing Enter nothing happens.

Workaround: The user can select Edit|Properties to then edit the card.

Comment 4

[scottputterman]

marking nsbeta1-.  When this does get fixed, we won't want 'b'.

Comment 5

[(not reading, please use [e-mail] instead)]

b) should be fixed for QS in both mail and addressbook.

sounds like what's needed for addressbook is:

a. clicking in the field containing a string only places the cursor --no selection.
c. there is no selection when hitting enter after typing a string.

oh, to find time to write the XBL for a timed text input widget to be shared in
threadpane, addressbook, addressbook side bar, select address dialog, subscribe
dialog, etc...

Comment 6

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 7

[Cavin Song]

Reassigning.

Comment 8

[shliang]

Attachment: patch

i was a little confused by the comments, but this patch does a, b, and c for
mail and addressbook quicksearch and should also fix bug 126314

Comment 9

[Cavin Song]

Comment on attachment 114261 [details] [diff] [review]
patch

r=cavin.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 114261 [details] [diff] [review]
patch

r/sr=sspitzer, except don't check in the abCommon.js fix, that looks like it is
for something else.

Comment 11

[shliang]

marking fixed.

Comment 12

[Ninoschka Baca]

Reopening

Trunk build 2003-03-03: WinXP, Linux RH 8
I think this bug should have fixed items "a" and "c" but not "b" since it was
addressed in bug# 128500.

a. Fixed
b. The fix in bug 128500 is no longer working. Reopening due to this issue.
c. Fixed

Comment 13

[shliang]

Attachment: taking out item "b"

i misunderstood the comments, thought the text was supposed to be selected
after the pause.
taking that out now

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 116157 [details] [diff] [review]
taking out item "b"

r/sr=sspitzer, assuming you are just reverting the change, and you've tested
well.

good catch, ninoschka.

Comment 15

[(not reading, please use [e-mail] instead)]

oops, not ninoschka, sarah found it.

Comment 16

[Cavin Song]

Comment on attachment 116157 [details] [diff] [review]
taking out item "b"

r=cavin.

Comment 17

[shliang]

reverted changes for b

Comment 18

[Ninoschka Baca]

Trunk build 2003-03-05: Mac 10.1.5, WinxP
Verified Fixed. Items a, b and c all work as expected. Great!