128560 - Fail when Async Proxy methods are passed out or in-out params

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nisheeth Ranjan]

Currently, we don't check method invocations on async proxy objects to see
whether out or in-out parameters are being passed.  Since such parameters have
indeterminate values in the async case, we want to return an explicit error when
such parameters are passed to methods through the async proxy.

Comment 1

[Doug Turner (:dougt)]

Attachment: Fail if we detect a dipper in an async proxy.

During converstion from a mini variant to a full variant, we check to see if
the paramater is a dipper.  If it is, we fail.	This will cause the Async call
to return an error code and NOT post an event.

Comment 2

[scottputterman]

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to [e-mail].  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.

Comment 3

[Doug Turner (:dougt)]

ugh.  moving back to moz1.0 tm.

Comment 4

[rpotts (gone)]

Comment on attachment 72272 [details] [diff] [review]
Fail if we detect a dipper in an async proxy.

sr=[e-mail]... after changing the NS_ERROR_FAILURE to a more 'proxy
specific' failure code.

(as dougt and i discussed)

Comment 5

[John Bandhauer]

Comment on attachment 72272 [details] [diff] [review]
Fail if we detect a dipper in an async proxy.

>+        if (mProxyType & PROXY_ASYNC && paramInfo.IsDipper())

Maybe I'm a wimp, but I'd rather see:

	  if ((mProxyType & PROXY_ASYNC) && paramInfo.IsDipper())

Comment 6

[Doug Turner (:dougt)]

both suggestions added.  thanks.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 72272 [details] [diff] [review]
Fail if we detect a dipper in an async proxy.

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 8

[Doug Turner (:dougt)]

Checking in src/nsProxyEvent.cpp;
/cvsroot/mozilla/xpcom/proxy/src/nsProxyEvent.cpp,v  <--  nsProxyEvent.cpp
new revision: 1.70; previous revision: 1.69
done

Fix checked into trunk.  Nisheeth, does this also need to land on any branch??

Comment 9

[Doug Turner (:dougt)]

Looking at 125466, I do not think that this is meant for .99.  Marking fixed.