1286482 - SetUserTimeAndStartupIDForActivatedWindow tries to access nsWindow.mIsX11Display (cannot compile with MOZ_ENABLE_STARTUP_NOTIFICATION)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Tooru Fujisawa [:arai]]

> static void
> SetUserTimeAndStartupIDForActivatedWindow(GtkWidget* aWindow)
> {
> ...
> #if defined(MOZ_ENABLE_STARTUP_NOTIFICATION)
>     // TODO - Implement for non-X11 Gtk backends (Bug 726479)
>     if (mIsX11Display) {

This is not nsWindow's method and cannot access mIsX11Display.

> void
> nsWindow::NativeShow(bool aAction)
> {
> ...
>                 SetUserTimeAndStartupIDForActivatedWindow(mShell);

mIsX11Display should be passed from here.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, Back Jun 24)]

Attachment: patch

Patch from Bug 1215104.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d246a11b20a

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2c3da5ac021
use gdk_display_get_default() instead of mIsX11Display attribute, r=karlt

Comment 3

[Karl Tomlinson (:karlt)]

[Tracking Requested - why for this release]:
regression from bug 1215104, breaking compilation with common configuration.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2c3da5ac021

Comment 5

[Mike Hommey [:glandium]]

Martin, can you request an uplift to aurora?

Comment 6

[Martin Stránský [:stransky] (ni? me) (PTO, Back Jun 24)]

Comment on attachment 8776498 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: #1215104
[User impact if declined]: Fails to build when start-up notification is enabled
[Describe test coverage new/current, TreeHerder]: no test, we don't build with enabled start-up notification
[Risks and why]: No risk at all
[String/UUID change made/needed]: None

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked since its a regression.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8776498 [details] [diff] [review]
patch

Fixes a regression, Aurora50+

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/08d91d70099b