12896 - Launch browser, mail/news DLLs loaded

Status: RESOLVED WONTFIX

(SeaMonkey :: General, defect)

Description

[Phil Peterson]

When I launch apprunner to the browser, I see the NT loader rebasing
msgbase.dll, msgbsutl.dll and mork.dll. Doesn't seem like these mail/news
components should be loaded when the browser launches.

Comment 1

[Phil Peterson]

Triage to M15

Comment 2

[Scott MacGregor]

triaging since M15 is tonight. Not an M15 stoppper.

Comment 3

[scottputterman]

moving to future milestone.  This is too complicated and risky to fix now.

Comment 4

[Blake Ross]

Time to pull this in yet?  I think we need mork for history (alec, bienvenu?), 
but the others can probably go.

Comment 5

[David :Bienvenu]

Mork is needed for history, and is not part of mail/news proper (it's in the
mozilla/db directory, not mozilla/mailnews.

But the reason mail/news dlls get loaded is because your localstore.rdf mentions
mail/news URI's, which causes our dlls to get loaded. That's what Scott is
saying is too complicated to fix anytime soon, having mail/news URI's in 
localstore.rdf NOT cause mail/news dlls to get loaded.

Comment 6

[Alec Flett]

yes, fixing this problem the 'right' way is rediculously hard - there's a bug
assigned to sspitzer about using RDF delegates for mail objects, that's the
'right' way to fix this bug.

The other way to 'fix' this bug is to break localstore.rdf into a per-chrome
file, such that localstore-messenger.rdf doesn't get loaded until a
chrome://messenger url is loaded. CC'ing waterson and hyatt to see what they
think, since it's a XUL issue and a bloat issue.

Comment 7

[Daniel Veditz [:dveditz]]

nominating for the potentially easier fix (splitting the mail part of 
localstore into a separate file).  We're slow enough at startup (most of the 
time spent loading libraries) without adding extra libraries we could delay.

Comment 8

[scottputterman]

marking nsbeta1- but nscatfood+.  I've been told by waterson that the fix that 
dveditz is proposing is not easy.  If you can find out a way to do this that's 
easy then we can look into this.

Comment 9

[Daniel Veditz [:dveditz]]

How can this be both nsbeta1 AND nsbeta1- ?  You're confusing the queries.

Comment 10

[Håkan Waara]

Dan: Apparently, putterman forgot to remove the nsbeta1 keyword when he minused
it. Doing so now..

Comment 11

[Cathleen]

msgimap.dll    270,336
msgbsutl.dll   143,360                                                          
                          
are still loaded on startup as of the latest win32 build.                       
 

Comment 12

[scottputterman]

*** Bug 46800 has been marked as a duplicate of this bug. ***

Comment 13

[scottputterman]

Yes, I forgot to remove the nsbeta1.  I'm sorry I confused the queries that I'm
pretty sure I was the only one looking at.

I know two ways to solve this:

1.  Rewrite mailnews folder RDF code.  That's not going to happen at the moment.

2.  Make it so that localstore.rdf can be split into a mailstore.rdf.  The last
I talked to waterson, I was told this would be really hard.  Chris any comments
on what the risk would be in doing this?

Comment 14

[scottputterman]

waterson also suggested the idea of persisting these values ourselves instead of
using localstore. That's under investigation.

Comment 15

[scottputterman]

marking nsbeta1+ and moving to 0.9.1  reassingning to bienvenu.

Comment 16

[scottputterman]

moving to 0.9.2 but if you're able to get to this this before, then go for it.

Comment 17

[David :Bienvenu]

Attachment: patch to store all the view stuff in the db

Comment 18

[David :Bienvenu]

Can I get an r/sr= for this patch? The remaining work is to persist the elided
flag for folders, which I'll attack later.

Comment 19

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 20

[David :Bienvenu]

I checked in this patch - the remaining work is to use the elided bit for the
expand collapse state of folders. 

Comment 21

[Alec Flett]

should we open another bug to clear out the old resources from localstore.rdf?
Otherwise people who upgraded from N6.0x will still get the dlls loaded

Comment 22

[David :Bienvenu]

Is that even technically possible, Alec, other than writing special code to
grope through the file? We can't assume that the current folders are the set of
folders the user might have ever had stored in localstore.rdf

Comment 23

[Alec Flett]

argh.. I just looked at localstore, I thought they were all in a sequence off of
a well-known resource, but actually all you have to do is call GetAllResources
on the localstore datasource, and for each resource:
   if it has an imap:, mailbox: or news: schema, 
     remove all arcs coming out of it.

Comment 24

[scottputterman]

adding PDT+

Comment 25

[scottputterman]

moving this to future.  It looks like the rest of this bug will get fixed with
the Folder Pane rewrite.  Let's keep this around to make sure.

Comment 26

[lchiang]

Since the rest of this bug is assigned to future, I am going to remove the PDT+.

Comment 27

[Scott MacGregor]

Seth, now that the folder outliner has landed is this fixed? putterman said he
thought this was going to just start working once the folder pane branch landed
but I'm not so sure. We still use RDF in the folder pane. We are just using the
bridge to talk to the outliner widget. So in theory the same RDF problems should
still be there. 

Comment 28

[David :Bienvenu]

in theory, this should be fixed - we still use rdf, but the tree is no longer
persisting folder uris for things like expand/collapse state (because we're not
using the tree widget), so we shouldn't have folder uris written to localstore.rdf

Comment 29

[Alec Flett]

If I am a N6 or N6.1 user, aren't we going to load the mail dlls anyway, even if
we aren't using them, because I have the resources in my localstore.rdf? 

I'd like to suggest that we have some pref like "mailnews.localstore.clean" that
defaults false... when mail starts (or a dll is loaded) we could check that
pref, and if it's false, then we walk localstore.rdf and remove all mail
resources...

Comment 30

[Martin Poirier]

I think this is related to bug 106087. Maybe not exactly a dupe because it is
about another dll, but perhaps we could merge the 2 bugs or something like that
or at least work combine the efforts made in these 2 bugs.

Comment 31

[David :Bienvenu]

taking to check if fixed...

Comment 32

[Worcester12345]

(In reply to comment #31)
> taking to check if fixed...

Was it? Bitrot? Thanks.

Comment 33

[David :Bienvenu]

this is now a seamonkey issue, if it's an issue at all...marking wontfix

Comment 34

[Mike Fedyk]

If this is for seamonkey, then it should be set to Moz App Suite.

Comment 35

[Robert Kaiser]

Mail/news is an integral piece of SeaMonkey, by default we're even checking for new mails on browser startup now. WONTFIX.