1290375 - In case of crashes for a Marionette test the current test file name has to be logged instead of runner.py

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

A good example you can see here:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6e95ea056bf5805c39e141de567f16068b214307&selectedJob=32861414&filter-searchStr=e10s%20fxfn

> PROCESS-CRASH | runner.py | application crashed [@ libc-2.15.so + 0xe7993]

Given that lots of test harnesses have such a file we see dozen of possible bug suggestions on Treeherder. Since yesterday we even collapse all and only show a warning. As result you do not even see bug suggestions anymore.

We should make sure that we log the test file name where the crash happened.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I would like to wait for bug 1202392 which might already improve the situation.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So the problem here is that the marionette-server side seems to fail to set the test_name correctly:

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette_driver/marionette.py#1142

Because of that we are passing None into the mozcrash checker, which then simply uses runner.py.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So the if condition is not necessary at all here. In case of failures `_send_message()` would raise an exception. When removing it I get correct test file names in the crash report line:

> PROCESS-CRASH | test_addons.py TestSomething.test_crash | application crashed [@ Crash]

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1290375 - Marionette has to report the test name and not runner.py for crashes.

Review commit: https://reviewboard.mozilla.org/r/69556/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69556/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8778243 [details]
Bug 1290375 - Marionette has to report the test name and not runner.py for crashes.

https://reviewboard.mozilla.org/r/69556/#review66704

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/009c0f237a44
Marionette has to report the test name and not runner.py for crashes. r=ato

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/009c0f237a44

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This helps starring busted mariontte test jobs due to crashes. It would be great to get this backported to aurora and beta.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/67df3228b1e8
https://hg.mozilla.org/releases/mozilla-beta/rev/6a680c86119d