Closed Bug 1302566 Opened 8 years ago Closed 22 days ago

remove the IsInPrivateBrowsing mode from shared workers and use origin attributes instead.

Categories

(Core :: DOM: Security, defect, P3)

Product:
Core
Component:
DOM: Security
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed
firefox57 --- fix-optional

People

(Reporter: huseby, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor][domsecurity-backlog1][OA])

Attachments

(1 file, 1 obsolete file)

oa.patch
2.03 KB, patch
tanvi
: review+
Details | Diff | Splinter Review 
in Bug 1268726 we added the isolation of shared workers by origin attributes.  the shared workers code still contains a separate boolean for whether they are in private browsing mode or not.  this should be removed and the origin attributes used instead.
No longer blocks: FirstPartyIsolation
Priority: P2 → P3
Whiteboard: [tor][domsecurity-active][ETA 10/10] → [tor][domsecurity-active][OA]
Whiteboard: [tor][domsecurity-active][OA] → [tor][domsecurity-backlog1][OA]
Assignee: nobody → amarchesini
Attached patch oa.patch (obsolete) — — Splinter Review 

        Attachment #8828893 -
        Flags: review?(ehsan)

    
    

    
  
Comment on attachment 8828893 [details] [diff] [review]
oa.patch

Review of attachment 8828893 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW I was trying to figure out why the patch here is doing something entirely different than comment 0 and I realized that comment 0 is a mistake, that boolean flag was removed in bug 1268726.

        Attachment #8828893 -
        Flags: review?(ehsan) → review+

    
    

    
  
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e942ed64921
Get rid of nsContentUtils::IsInPrivateBrowsing, r=ehsan

    
    

    
  
Backed out for mass test failures after asserting isPrivate == mRespectPrivacy at imgLoader.cpp:2072:

https://hg.mozilla.org/integration/mozilla-inbound/rev/13b48d5e00f4b98718f2a16cac1b2ae2bc7c00c1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2e942ed649214673eb6f52ba0f8bd8605d792181
Failure log: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2e942ed649214673eb6f52ba0f8bd8605d792181

[task 2017-01-23T12:11:53.188933Z] 12:11:53     INFO - TEST-START | dom/broadcastchannel/tests/browser_private_browsing.js
[task 2017-01-23T12:11:53.204843Z] 12:11:53     INFO - Chrome file doesn't exist: /home/worker/workspace/build/tests/mochitest/browser/dom/broadcastchannel/tests/head.js
[task 2017-01-23T12:11:53.236532Z] 12:11:53     INFO - ++DOCSHELL 0xe61d9c00 == 9 [pid = 1638] [id = {550aafe6-257c-45ac-b0ac-b6961b924b63}]
[task 2017-01-23T12:11:53.239098Z] 12:11:53     INFO - ++DOMWINDOW == 20 (0xe61da400) [pid = 1638] [serial = 20] [outer = (nil)]
[task 2017-01-23T12:11:53.243489Z] 12:11:53     INFO - ++DOMWINDOW == 21 (0xe61e0800) [pid = 1638] [serial = 21] [outer = 0xe61da400]
[task 2017-01-23T12:11:53.308280Z] 12:11:53     INFO - ++DOMWINDOW == 22 (0xd7b22c00) [pid = 1638] [serial = 22] [outer = 0xd2494400]
[task 2017-01-23T12:11:53.471163Z] 12:11:53     INFO - ++DOCSHELL 0xd7b29400 == 10 [pid = 1638] [id = {5b510221-598e-49cc-a4f8-64fdab21e5c4}]
[task 2017-01-23T12:11:53.471606Z] 12:11:53     INFO - ++DOMWINDOW == 23 (0xd7b29800) [pid = 1638] [serial = 23] [outer = (nil)]
[task 2017-01-23T12:11:53.495353Z] 12:11:53     INFO - ++DOCSHELL 0xd7b2a400 == 11 [pid = 1638] [id = {a6091626-3d6d-4549-9a70-4ee90efc2c78}]
[task 2017-01-23T12:11:53.497128Z] 12:11:53     INFO - ++DOMWINDOW == 24 (0xd7b2a800) [pid = 1638] [serial = 24] [outer = (nil)]
[task 2017-01-23T12:11:53.759004Z] 12:11:53     INFO - ++DOCSHELL 0xea85e800 == 12 [pid = 1638] [id = {28b4fc0e-a78c-4bde-b036-2ead58e6f5c8}]
[task 2017-01-23T12:11:53.760862Z] 12:11:53     INFO - ++DOMWINDOW == 25 (0xea90f400) [pid = 1638] [serial = 25] [outer = (nil)]
[task 2017-01-23T12:11:53.839972Z] 12:11:53     INFO - ++DOMWINDOW == 26 (0xd7e52000) [pid = 1638] [serial = 26] [outer = 0xea90f400]
[task 2017-01-23T12:11:54.126373Z] 12:11:54     INFO - ++DOMWINDOW == 27 (0xd4181800) [pid = 1638] [serial = 27] [outer = 0xd7b29800]
[task 2017-01-23T12:11:54.146643Z] 12:11:54     INFO - ++DOMWINDOW == 28 (0xd7e56400) [pid = 1638] [serial = 28] [outer = 0xd7b2a800]
[task 2017-01-23T12:11:54.163470Z] 12:11:54     INFO - ++DOMWINDOW == 29 (0xd7e57c00) [pid = 1638] [serial = 29] [outer = 0xea90f400]
[task 2017-01-23T12:11:54.444215Z] 12:11:54     INFO - Assertion failure: isPrivate == mRespectPrivacy, at /home/worker/workspace/build/src/image/imgLoader.cpp:2072
[task 2017-01-23T12:11:54.444554Z] 12:11:54     INFO - #01: imgLoader::LoadImage [image/imgLoader.cpp:2134]
[task 2017-01-23T12:11:54.444668Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.446535Z] 12:11:54     INFO - #02: nsContentUtils::LoadImage [dom/base/nsContentUtils.cpp:3293]
[task 2017-01-23T12:11:54.447723Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.450814Z] 12:11:54     INFO - #03: mozilla::css::ImageLoader::LoadImage [xpcom/string/nsTSubstring.h:95]
[task 2017-01-23T12:11:54.452064Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.459794Z] 12:11:54     INFO - #04: mozilla::css::ImageValue::Initialize [layout/style/nsCSSValue.cpp:2955]
[task 2017-01-23T12:11:54.461160Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.462836Z] 12:11:54     INFO - #05: mozilla::css::ImageValue::ImageValue [layout/style/nsCSSValue.cpp:2925]
[task 2017-01-23T12:11:54.464194Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.465818Z] 12:11:54     INFO - #06: nsCSSValue::StartImageLoad [layout/style/nsCSSValue.cpp:848]
[task 2017-01-23T12:11:54.467283Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.470035Z] 12:11:54     INFO - #07: TryToStartImageLoadOnValue [layout/style/nsCSSDataBlock.cpp:99]
[task 2017-01-23T12:11:54.471400Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.473029Z] 12:11:54     INFO - #08: TryToStartImageLoad [layout/style/nsCSSDataBlock.cpp:132]
[task 2017-01-23T12:11:54.474663Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.482641Z] 12:11:54     INFO - #09: MapSinglePropertyInto [layout/style/nsCSSDataBlock.cpp:188]
[task 2017-01-23T12:11:54.484736Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.488893Z] 12:11:54     INFO - #10: nsCSSCompressedDataBlock::MapRuleInfoInto [layout/style/nsCSSDataBlock.cpp:333]
[task 2017-01-23T12:11:54.490765Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.492673Z] 12:11:54     INFO - #11: mozilla::css::Declaration::MapRuleInfoInto [layout/style/Declaration.cpp:101]
[task 2017-01-23T12:11:54.494546Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.499049Z] 12:11:54     INFO - #12: nsRuleNode::WalkRuleTree [layout/style/nsRuleNode.cpp:2513]
[task 2017-01-23T12:11:54.504162Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.505863Z] 12:11:54     INFO - #13: nsRuleNode::GetStyleBackground<true> [obj-firefox/dist/include/nsStyleStructList.h:81]
[task 2017-01-23T12:11:54.507050Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.508684Z] 12:11:54     INFO - #14: nsStyleContext::DoGetStyleBackground<true> [layout/style/nsStyleContext.h:575]
[task 2017-01-23T12:11:54.509881Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.511826Z] 12:11:54     INFO - #15: nsStyleContext::CalcStyleDifferenceInternal<nsStyleContext, (nsStyleContext::NeutralChangeHandling)1> [layout/style/nsStyleContext.cpp:1106]
[task 2017-01-23T12:11:54.513608Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.515608Z] 12:11:54     INFO - #16: mozilla::ElementRestyler::CaptureChange [layout/base/RestyleManager.cpp:1600]
[task 2017-01-23T12:11:54.521454Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.523137Z] 12:11:54     INFO - #17: mozilla::ElementRestyler::RestyleSelf [layout/base/RestyleManager.cpp:2976]
[task 2017-01-23T12:11:54.524520Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.526082Z] 12:11:54     INFO - #18: mozilla::ElementRestyler::Restyle [layout/base/RestyleManager.cpp:2139]
[task 2017-01-23T12:11:54.527951Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.529999Z] 12:11:54     INFO - #19: mozilla::ElementRestyler::RestyleContentChildren [layout/base/RestyleManager.cpp:3727]
[task 2017-01-23T12:11:54.532041Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.533889Z] 12:11:54     INFO - #20: mozilla::ElementRestyler::RestyleChildren [layout/base/RestyleManager.cpp:3249]
[task 2017-01-23T12:11:54.537796Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.539633Z] 12:11:54     INFO - #21: mozilla::ElementRestyler::Restyle [layout/base/RestyleManager.cpp:2292]
[task 2017-01-23T12:11:54.541425Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.543300Z] 12:11:54     INFO - #22: mozilla::ElementRestyler::RestyleContentChildren [layout/base/RestyleManager.cpp:3727]
[task 2017-01-23T12:11:54.548120Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.551957Z] 12:11:54     INFO - #23: mozilla::ElementRestyler::RestyleChildren [layout/base/RestyleManager.cpp:3249]
[task 2017-01-23T12:11:54.553348Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.554965Z] 12:11:54     INFO - #24: mozilla::ElementRestyler::Restyle [layout/base/RestyleManager.cpp:2292]
[task 2017-01-23T12:11:54.556240Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.557897Z] 12:11:54     INFO - #25: mozilla::ElementRestyler::RestyleContentChildren [layout/base/RestyleManager.cpp:3727]
[task 2017-01-23T12:11:54.559695Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.563108Z] 12:11:54     INFO - #26: mozilla::ElementRestyler::RestyleChildren [layout/base/RestyleManager.cpp:3249]
[task 2017-01-23T12:11:54.564858Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.566761Z] 12:11:54     INFO - #27: mozilla::ElementRestyler::Restyle [layout/base/RestyleManager.cpp:2292]
[task 2017-01-23T12:11:54.568429Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.575954Z] 12:11:54     INFO - #28: mozilla::ElementRestyler::RestyleContentChildren [layout/base/RestyleManager.cpp:3727]
[task 2017-01-23T12:11:54.577374Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.578962Z] 12:11:54     INFO - #29: mozilla::ElementRestyler::RestyleChildren [layout/base/RestyleManager.cpp:3249]
[task 2017-01-23T12:11:54.580206Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.582092Z] 12:11:54     INFO - #30: mozilla::ElementRestyler::Restyle [layout/base/RestyleManager.cpp:2292]
[task 2017-01-23T12:11:54.585865Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.587517Z] 12:11:54     INFO - #31: mozilla::ElementRestyler::RestyleContentChildren [layout/base/RestyleManager.cpp:3727]
[task 2017-01-23T12:11:54.588858Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.590437Z] 12:11:54     INFO - #32: mozilla::ElementRestyler::RestyleChildren [layout/base/RestyleManager.cpp:3249]
[task 2017-01-23T12:11:54.591607Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.597237Z] 12:11:54     INFO - #33: mozilla::ElementRestyler::Restyle [layout/base/RestyleManager.cpp:2292]
[task 2017-01-23T12:11:54.601247Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.602867Z] 12:11:54     INFO - #34: mozilla::ElementRestyler::ComputeStyleChangeFor [layout/base/RestyleManager.cpp:3393]
[task 2017-01-23T12:11:54.604652Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.607374Z] 12:11:54     INFO - #35: mozilla::RestyleManager::ComputeAndProcessStyleChange [layout/base/RestyleManager.cpp:3805]
[task 2017-01-23T12:11:54.608760Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.611522Z] 12:11:54     INFO - #36: mozilla::RestyleManager::RestyleElement [layout/base/RestyleManager.cpp:154]
[task 2017-01-23T12:11:54.612883Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.614621Z] 12:11:54     INFO - #37: mozilla::RestyleTracker::ProcessOneRestyle [layout/base/RestyleTracker.cpp:96]
[task 2017-01-23T12:11:54.616274Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.623906Z] 12:11:54     INFO - #38: mozilla::RestyleTracker::DoProcessRestyles [layout/base/RestyleTracker.cpp:264]
[task 2017-01-23T12:11:54.625874Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.628079Z] 12:11:54     INFO - #39: mozilla::RestyleManager::ProcessPendingRestyles [layout/base/RestyleManager.cpp:837]
[task 2017-01-23T12:11:54.631633Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.633467Z] 12:11:54     INFO - #40: mozilla::PresShell::ResizeReflowIgnoreOverride [layout/base/PresShell.cpp:1891]
[task 2017-01-23T12:11:54.634805Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.636357Z] 12:11:54     INFO - #41: nsViewManager::DoSetWindowDimensions [view/nsViewManager.cpp:192]
[task 2017-01-23T12:11:54.637689Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.639223Z] 12:11:54     INFO - #42: nsDocumentViewer::SetBoundsWithFlags [layout/base/nsDocumentViewer.cpp:1972]
[task 2017-01-23T12:11:54.640589Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.642135Z] 12:11:54     INFO - #43: nsDocShell::SetPositionAndSize [docshell/base/nsDocShell.cpp:5960]
[task 2017-01-23T12:11:54.643324Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.645184Z] 12:11:54     INFO - #44: nsWebShellWindow::WindowResized [xpfe/appshell/nsWebShellWindow.cpp:298]
[task 2017-01-23T12:11:54.646388Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.648778Z] 12:11:54     INFO - #45: nsWindow::DispatchResized [widget/gtk/nsWindow.cpp:550]
[task 2017-01-23T12:11:54.650258Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.652027Z] 12:11:54     INFO - #46: nsWindow::Resize [widget/gtk/nsWindow.cpp:1131]
[task 2017-01-23T12:11:54.655529Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.657120Z] 12:11:54     INFO - #47: nsXULWindow::SetSize [xpfe/appshell/nsXULWindow.cpp:584]
[task 2017-01-23T12:11:54.658324Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.659978Z] 12:11:54     INFO - #48: nsXULWindow::SetSpecifiedSize [xpfe/appshell/nsXULWindow.cpp:1225]
[task 2017-01-23T12:11:54.661165Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.664199Z] 12:11:54     INFO - #49: nsXULWindow::OnChromeLoaded [xpfe/appshell/nsXULWindow.cpp:1024]
[task 2017-01-23T12:11:54.665634Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.667224Z] 12:11:54     INFO - #50: nsWebShellWindow::OnStateChange [xpfe/appshell/nsWebShellWindow.cpp:624]
[task 2017-01-23T12:11:54.668799Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.670674Z] 12:11:54     INFO - #51: nsDocLoader::DoFireOnStateChange [uriloader/base/nsDocLoader.cpp:1255]
[task 2017-01-23T12:11:54.672603Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.676063Z] 12:11:54     INFO - #52: nsDocLoader::doStopDocumentLoad [uriloader/base/nsDocLoader.cpp:850]
[task 2017-01-23T12:11:54.677261Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.678888Z] 12:11:54     INFO - #53: nsDocLoader::DocLoaderIsEmpty [uriloader/base/nsDocLoader.cpp:732]
[task 2017-01-23T12:11:54.680219Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.682034Z] 12:11:54     INFO - #54: nsDocLoader::DocLoaderIsEmpty [uriloader/base/nsDocLoader.h:201]
[task 2017-01-23T12:11:54.683719Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.685993Z] 12:11:54     INFO - #55: nsDocLoader::OnStopRequest [uriloader/base/nsDocLoader.cpp:612]
[task 2017-01-23T12:11:54.687576Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.691769Z] 12:11:54     INFO - #56: mozilla::net::nsLoadGroup::RemoveRequest [netwerk/base/nsLoadGroup.cpp:635]
[task 2017-01-23T12:11:54.693361Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.694911Z] 12:11:54     INFO - #57: nsDocument::DoUnblockOnload [dom/base/nsDocument.cpp:8694]
[task 2017-01-23T12:11:54.696250Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.697767Z] 12:11:54     INFO - #58: nsDocument::UnblockOnload [dom/base/nsDocument.cpp:8620]
[task 2017-01-23T12:11:54.698946Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.705456Z] 12:11:54     INFO - #59: nsDocument::DispatchContentLoadedEvents [dom/base/nsDocument.cpp:5075]
[task 2017-01-23T12:11:54.709293Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.711203Z] 12:11:54     INFO - #60: mozilla::detail::RunnableMethodArguments<>::apply<nsDocument, void (nsDocument::*)()> [xpcom/glue/nsThreadUtils.h:825]
[task 2017-01-23T12:11:54.712974Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.716105Z] 12:11:54     INFO - #61: mozilla::detail::RunnableMethodImpl<nsDocument*, void (nsDocument::*)(), true, false>::Run [xpcom/glue/nsThreadUtils.h:860]
[task 2017-01-23T12:11:54.717605Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.719235Z] 12:11:54     INFO - #62: nsThread::ProcessNextEvent [xpcom/threads/nsThread.cpp:1240]
[task 2017-01-23T12:11:54.720854Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.722664Z] 12:11:54     INFO - #63: NS_ProcessNextEvent [xpcom/glue/nsThreadUtils.cpp:390]
[task 2017-01-23T12:11:54.725613Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.727291Z] 12:11:54     INFO - #64: mozilla::ipc::MessagePump::Run [ipc/glue/MessagePump.cpp:97]
[task 2017-01-23T12:11:54.728791Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.730497Z] 12:11:54     INFO - #65: MessageLoop::RunInternal [ipc/chromium/src/base/message_loop.cc:238]
[task 2017-01-23T12:11:54.732051Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.733905Z] 12:11:54     INFO - #66: MessageLoop::Run [ipc/chromium/src/base/message_loop.cc:502]
[task 2017-01-23T12:11:54.735651Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.741588Z] 12:11:54     INFO - #67: nsBaseAppShell::Run [widget/nsBaseAppShell.cpp:158]
[task 2017-01-23T12:11:54.742902Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.744548Z] 12:11:54     INFO - #68: nsAppStartup::Run [toolkit/components/startup/nsAppStartup.cpp:284]
[task 2017-01-23T12:11:54.745989Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.747640Z] 12:11:54     INFO - #69: XREMain::XRE_mainRun [toolkit/xre/nsAppRunner.cpp:4462]
[task 2017-01-23T12:11:54.748997Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.750522Z] 12:11:54     INFO - #70: XREMain::XRE_main [toolkit/xre/nsAppRunner.cpp:4638]
[task 2017-01-23T12:11:54.751684Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.753474Z] 12:11:54     INFO - #71: XRE_main [toolkit/xre/nsAppRunner.cpp:4730]
[task 2017-01-23T12:11:54.754817Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.756612Z] 12:11:54     INFO - #72: do_main [browser/app/nsBrowserApp.cpp:234]
[task 2017-01-23T12:11:54.758870Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.760521Z] 12:11:54     INFO - #73: main [browser/app/nsBrowserApp.cpp:307]
[task 2017-01-23T12:11:54.762170Z] 12:11:54     INFO - 
[task 2017-01-23T12:11:54.800130Z] 12:11:54     INFO - ExceptionHandler::GenerateDump cloned child 1696
[task 2017-01-23T12:11:54.800476Z] 12:11:54     INFO - ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2017-01-23T12:11:54.803789Z] 12:11:54     INFO - ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2017-01-23T12:11:55.657167Z] 12:11:55     INFO - TEST-INFO | Main app process: exit 11
[task 2017-01-23T12:11:55.657617Z] 12:11:55    ERROR - TEST-UNEXPECTED-FAIL | ShutdownLeaks | process() called before end of test suite
Flags: needinfo?(amarchesini)

    
    

    
  
There is another failure: https://treeherder.mozilla.org/logviewer.html#?job_id=71150855&repo=mozilla-inbound
[task 2017-01-23T12:13:59.553616Z] 12:13:59     INFO - TEST-START | dom/cache/test/mochitest/browser_cache_pb_window.js
[task 2017-01-23T12:14:00.547190Z] 12:14:00     INFO - TEST-INFO | started process screentopng
[task 2017-01-23T12:14:01.506058Z] 12:14:01     INFO - TEST-INFO | screentopng: exit 0
[task 2017-01-23T12:14:01.509459Z] 12:14:01     INFO - TEST-UNEXPECTED-FAIL | dom/cache/test/mochitest/browser_cache_pb_window.js | caches.match() should not return success - 
[task 2017-01-23T12:14:01.509650Z] 12:14:01     INFO - Stack trace:
[task 2017-01-23T12:14:01.510019Z] 12:14:01     INFO - chrome://mochitests/content/browser/dom/cache/test/mochitest/browser_cache_pb_window.js:testMatch/</<:6
[task 2017-01-23T12:14:01.513629Z] 12:14:01     INFO - Not taking screenshot here: see the one that was previously logged

    
    

    
  
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc0405393d09
Get rid of nsContentUtils::IsInPrivateBrowsing, r=ehsan

    
  
Flags: needinfo?(amarchesini) → needinfo?(ehsan)

    
  
Flags: needinfo?(ehsan)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/fc0405393d09
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox54:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

    
    

    
  
baku, I'm nervous about this change.  Instead of using OA right away, we shoudl assert that the OA pbmode flag is equal to the boolean.  Then after 1 release cycle, get rid of the boolean.

Can we back this out and change it?
Flags: needinfo?(amarchesini)

    
  
Blocks: 1335678

    
    

    
  
I filed bug 1335678 for that.
Flags: needinfo?(amarchesini)

    
    

    
  
Since bug 1335678 reverted a bunch of this, should this be reopened?

    
    

    
  
reverted in bug 1335678 comment 10 https://hg.mozilla.org/mozilla-central/rev/7c00dba4cfdf
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See Also:  → 1380341

    
    

    
  

      
      
      
      

        Attached patch
          
          
        oa.patch
        — 
          — Splinter Review
      

    


  
I would like to continue with this bug. Following what tanvi suggested, what about if we land this patch and we wait for a while? If we don't see crashes, we can proceed.

        Attachment #8828893 -
        Attachment is obsolete: true

        Attachment #8931276 -
        Flags: review?(tanvi)

    
    

    
  
Comment on attachment 8931276 [details] [diff] [review]
oa.patch

Looks good.  Its been a while, so I'm not sure if we need MOZ_ASSERT or MOZ_DIAGNOSTIC_ASSERT here.

        Attachment #8931276 -
        Flags: review?(tanvi) → review+

    
  
Severity: normal → S3

    
    

    
  
This appears to have been done, or is obsolete. SharedWorkers don't check IsInPrivateBrowsing() anymore but they check whether storage is allowed on the window (where StorageAccess:: ePrivateBrowsing indicates private browsing).


Status: REOPENED → RESOLVED
Closed: 8 years ago → 22 days ago
Resolution: --- → WORKSFORME

    
    

    
  
(In reply to Daniel Veditz [:dveditz] from comment #15)




This appears to have been done, or is obsolete. SharedWorkers don't check IsInPrivateBrowsing() anymore but they check whether storage is allowed on the window (where StorageAccess:: ePrivateBrowsing indicates private browsing).




WFM is right for this bug (with the move to RemoteWorkers we match against principals and in particular require the same origin attributes), but it's worth calling out since it's not obvious, that since the partitioning was turned on that when in PBM StorageAccess is not constrained to just be ePrivateBrowsing, it can also be:


// The storage should be partitioned for third-party resources. if the
// caller is unable to do it, deny the storage access.
ePartitionForeignOrDeny = -2,
// The storage should be partitioned for third-party trackers. if the caller
// is unable to do it, deny the storage access.
ePartitionTrackersOrDeny = -1,



The medium term plan is to introduce a StorageKey abstraction (bug 1776271) to clean all of this up.



          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: