130317 - freeze nsIPassword.idl

Status: RESOLVED DUPLICATE of bug 130306

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Stephen P. Morse]

nsIPassword is the enumeration type for nsIPaswordManager. Because 
nsIPasswordManager is freezing, nsIPassword needs freezing as well.

Comment 1

[Stephen P. Morse]

Attachment: freeze for nsIPassword.idl

Comment 2

[Alec Flett]

is "host" in UTF8? This is the one thing we probably want to clarify.. if so
we'll probably need to change it to UTF8String adding darin, master of all hosts
utf8.

Comment 3

[Darin Fisher]

morse:

host should probably be UTF-8 in this interface.  even if you are currently
always passing ASCII via this interface, it is probably best moving forward to
allow UTF-8 hostnames.  that way we don't lock ourselves into an interface that
restricts i18n URL support.

how about changing to AString as well in place of wstring.  AString allows for
sharing of string buffers... and is generally much much better.

interface nsIPassword : nsISupports {
  readonly attribute AUTF8String host;
  readonly attribute AString user;
  readonly attribute AString password;
};

Comment 4

[Stephen P. Morse]

Attachment: Changing to AUTF8String and AString

Comment 5

[Stephen P. Morse]

Attachment: remove CONTRACT_ID per bug 130304 comment 21

Comment 6

[Alec Flett]

Comment on attachment 73940 [details] [diff] [review]
remove CONTRACT_ID per bug 130304 comment 21

sr=alecf

Comment 7

[timeless]

not that anyone cares, but the copyright block @ 
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/wallet/public/ns
IPassword.idl&rev=&root=/cvsroot&mark=#1 looks rather wrong... Mozilla is a 
project, not an entity, it doesn't hold copyrights.  Also shouldn't there be 
*'s on the blank lines too ;-?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Does "host" in this case mean "host" or "host:port" ?

Comment 9

[Stephen P. Morse]

It means whatever the caller of this interface cares to pass in.

Comment 10

[Alec Flett]

boris has a valid question though, and thus we need more comments - we should
document that it could mean either one, but that it is used to uniquely identify
hosts.. so that "newsserver:119" is not the same as just "newsserver"

Comment 11

[Stephen P. Morse]

Attachment: Expand on the definition of host

Comment 12

[Boris Zbarsky [:bzbarsky]]

Thank you, Stephen.

Comment 13

[timeless]

i'll repeat my other complaint here.
 you're marking a new file as (c) 1998, and you're describing these api's as 
for embedding.

do seamonkey and mozilla navigator not use them?

Comment 14

[Stephen P. Morse]

Combining this bug with 130306 because the patches for the two will have many 
files in common.

*** This bug has been marked as a duplicate of 130306 ***