1305103 - provide a way to refresh storage inspector cache storage and indexedDB views

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

At least for CacheStorage, the devtools storage inspector does not auto-update when a new entry is inserted into the Cache.  This is somewhat expected since we don't provide an async mechanism to be notified when this happens.

It might be nice, however, to provide a refresh button and possibly a timestamp indicating when the data was last refreshed.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This would also be useful for indexedDB as that is also a snapshot as opposed to a live view.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on Brobdingnagian.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on HOTFROG.

Comment 5

[Sebastian Zartner [:sebo]]

Mike, do you think that's something for a 'good-first-bug'?

Sebastian

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Sebastian Zartner [:sebo] from comment #5)
> Mike, do you think that's something for a 'good-first-bug'?
> 
> Sebastian

Possibly, although it is a little harder than most good first bugs.

Comment 7

[Sebastian Zartner [:sebo]]

Attachment: Bug 1305103 - Added a button to refresh the Storage Inspector display

Review commit: https://reviewboard.mozilla.org/r/167206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167206/

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8895929 [details]
Bug 1305103 - Added a button to refresh the Storage Inspector display

https://reviewboard.mozilla.org/r/167206/#review172506

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 8895929 [details]
Bug 1305103 - Added a button to refresh the Storage Inspector display

https://reviewboard.mozilla.org/r/167206/#review173028

::: devtools/client/themes/images/reload.svg:5
(Diff revision 1)
>  <!-- This Source Code Form is subject to the terms of the Mozilla Public
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 14 14" width="14" height="14">
> -  <path d="M12,7H6l2.4-2.4C7.6,4,6.6,3.8,5.5,4.1C4.3,4.5,3.3,5.5,3,6.8 C2.6,9,4.3,11,6.5,11c1,0,2-0.5,2.6-1.2l1.7,1c-1.3,1.6-3.3,2.5-5.6,2c-2-0.5-3.6-2.1-4-4.1C0.4,5.1,3.1,2,6.5,2 c1.3,0,2.4,0.4,3.3,1.2L12,1V7z"/>
> +  <path style="line-height:normal;font-variant-ligatures:normal;font-variant-position:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-feature-settings:normal;text-indent:0;text-align:start;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:#000000;text-transform:none;text-orientation:mixed;shape-padding:0;isolation:auto;mix-blend-mode:normal" d="M11.032 1.64v2.395c-.793-1.114-2-1.852-3.332-2.05-.538-.08-1.095-.074-1.652.03-2.23.417-3.9 2.288-4.067 4.55-.165 2.26 1.215 4.355 3.36 5.093 2.142.738 4.52-.063 5.782-1.947.427-.563-.473-1.164-.83-.554-1.01 1.51-2.908 2.15-4.627 1.557-1.72-.592-2.82-2.263-2.688-4.077.134-1.813 1.467-3.304 3.254-3.638 1.706-.32 3.396.5 4.226 2.002H7.64c-.677-.01-.677 1.01 0 1h3.812c.373 0 .58-.213.58-.582v-3.78c0-.74-1-.74-1 0z" color="#000" font-family="sans-serif" white-space="normal" overflow="visible" solid-color="#000000"/>

nit: remove style, color, font-family, white-space, overflow and solid-color attributes

Also, I think debugger-html has a reload icon you can use.

Comment 10

[Sebastian Zartner [:sebo]]

Comment on attachment 8895929 [details]
Bug 1305103 - Added a button to refresh the Storage Inspector display

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/167206/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b6e08391e33
Added a button to refresh the Storage Inspector display r=miker

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0b6e08391e33