1306449 - Add IPCMessageName to SendMessageW and SendMessage signatures

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Andrew McCreight [:mccr8]]

We crash in mozilla::ipc::ProcessLink::SendMessage and mozilla::ipc::ProcessLink::SendMessageW, usually when the message is too large, but it is important to know what the message actually is, so it would be good if the signature somehow contained the value of IPCMessageName.

For instance, it is PContent::Msg_PBlobConstructor in this crash:
bp-dd10b80e-4134-4238-896c-6f5642160929#tab-metadata

Comment 1

[Marco Castelluccio [:marco]]

I'll try to implement this.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3496

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f97937e6aa4f4008f039f907cf1734c23708ebce
Fixes bug 1306449 - Augment signatures that have the IPC Message Name annotation (#3496)

* Create new rule to augment signatures when the 'IPC Message Name' annotation is present

* Fix comment for the 'SignatureIPCChannelError' class

* Add SignatureIPCMessageName rule to the list of Mozilla rules

* Test the SignatureIPCMessageName rule

* Remove unused parameter

* Make the action of the SignatureIPCMessageName rule clearer

* Apply SignatureIPCMessageName rule before the SigTrunc one

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

This doesn't work. It uses ``raw_crash['ipc_message_name']`` but the field is actually called ``IPCMessageName`` in the raw_crash. Marco, do you want to fix that?

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3521

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/5ab7d5c56fb82fdc97bd29ea90bb5f10a0a64861
Fixes bug 1306449 - Use IPCMessageName from raw_crash, not ipc_message_name. (#3521)

Comment 7

[Peter Bengtsson [:peterbe]]

We have verified this in stage by reprocessing one crash and noticing that it gets the new correct signature.