131197 - need to implement nsIPluginTagInfo2::GetDocumentEncoding()

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect)

Description

[Denis Antrushin]

Java Plugin needs working nsIPluginTagInfo2::GetDocumentEncoding() to be able
display  non-ascii data passed as apple PARAMs

Comment 1

[Denis Antrushin]

Attachment: suggested fix, v1

Comment 2

[Denis Antrushin]

Here's implementation on GetDocumentEncoding.
I've taken <mozilla_bin>/res/charsetalias.properties and compared it with
http://java.sun.com/j2se/1.4/docs/guide/intl/encoding.doc.html.

I decided not to create separate file for encoding mapping and to hold
it (at runtime) in static hashtable which gets created upon first call to
GetDocumentEncoding() and lives as long as mozilla itself.

Suggestions and criticism are welcome :-)

Comment 3

[Patrick C. Beard]

Comment on attachment 74951 [details] [diff] [review]
suggested fix, v1

If the PL_strdup/ToNewUTF8String calls fail, you should return the appropriate
error.

Comment 4

[Denis Antrushin]

Attachment: suggested fix, v2

Return NS_ERROR_OUT_OF_MEMORY if failed to dup string

Comment 5

[Denis Antrushin]

Peter, Patrick, could you review latest patch, please?

Comment 6

[Peter Lubczynski]

Comment on attachment 75159 [details] [diff] [review]
suggested fix, v2

r=peterl ...but is there not a service that does this convertion for us?

Comment 7

[Peter Lubczynski]

Comment on attachment 75159 [details] [diff] [review]
suggested fix, v2

r=peterl ...but is there not a service that does this convertion for us?

Comment 8

[Denis Antrushin]

Nope. Here we need conversion from our standard charset names to java's names,
which are different. We only have a service which converts charset aliases to
their standard names...

Comment 9

[Patrick C. Beard]

Comment on attachment 75159 [details] [diff] [review]
suggested fix, v2

sr=beard

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 75159 [details] [diff] [review]
suggested fix, v2

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[Peter Lubczynski]

patch in trunk, marking FIXED.

Comment 12

[Patty Mac]

Verified the patch.

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

As roc just noticed, while "us-ascii" may be a common encoding, "us-acsii" is not.