131405 - wrong dates from windows ftp servers

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect, P3)

Description

[Frank Hofmann]

Mozilla shows wrong file dates (years) on a few ftp servers. Was only able to
spot it on 2 servers so far:
ftp://ftp.asuscom.de
ftp://ftp.asus.com

12.07.2001 -> 12.07.2201

Comment 1

[Bradley Baetz (:bbaetz)]

*boggle*

OK, so, ConvertDOSDate has some Issues.

Like only reading the second character in the month, for some unknown reason.
And deciding that to the way to work out the current century is ((year/1000 +
year/100) * 100), which gives (2+20)*100 ie 2200.
Oh, and it fails for two digit years < currentYear - years in the future should
have 100 subtraacted from them.

Confirming, but ->1.1, although I may get to this sooner. This routine needs to
be rewritten, I think. It also looks very fragile to failure, but then so is the
rest of that file.

Comment 2

[Bradley Baetz (:bbaetz)]

OK, this one was simple, so -> 1.0, and I'll attach the patch now

Comment 3

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 4

[Darin Fisher]

Comment on attachment 75800 [details] [diff] [review]
patch

sr=darin

how about some comments describing what aCStr is expected to look like?

Comment 5

[Bradley Baetz (:bbaetz)]

I'm not sure what it really needs to look like ;) I just know that a month has
two digits...

This parsing code is very ad-hoc, and needs to be rewritten/redesigned at some
point.

Comment 6

[Vinay Badami]

r=badami

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 75800 [details] [diff] [review]
patch

a=dbaron for trunk checkin.  (Also noting badami's review.)

(It seems to me like a +1 might be in order on that year check, though, since
this might not work too well for me on the afternoon of December 31, when you
Australians are already in the next year. :-)

Comment 8

[Bradley Baetz (:bbaetz)]

Yes - there is a separate bug on the off by one stuff, where we do it
differently (with different bugs) in 3 separate places. I'll fix this when I
create a common routine. IIRC, that bug is scheduled for 1.1

checked in.

Comment 9

[benc]

frank: does this work for you in RC1?

Comment 10

[Frank Hofmann]

I'm using the latest nightly build and it seems to work fine. Haven't noticed
any problems on ftp servers. :-)

Comment 11

[benc]

VERIFIED: per reporter

Comment 12

[benc]

The other site seems to be offline now, so I updated the URL.

I'm not sure this URL actually points to a site that has the describe behavior
anymore...

# ftp ftp.asuscom.de
Connected to ftp.asuscom.de.
220 Serv-U FTP Server v4.2 for WinSock ready...
Name (ftp.asuscom.de:root): root
331 User name okay, need password.
Password:
530 Not logged in.
Login failed.
ftp> user
(username) anonymous
331 User name okay, please send complete E-mail address as password.
Password: 
230-
230-----------------------------------------------------
230-
230-Willkommen auf dem FTP Server der ASUS Germany GmbH
230-
230-z.Z. befinden sich 94 von maximal 200
230-anonymen Benutzern auf diesem Server
230-
230-Limits:
230-maximal 200 anonyme Benutzer
230-maximal 2 Verbindung pro IP
230-
230-----------------------------------------------------
230-
230-Welcome to FTP Server of ASUS Germany GmbH
230-
230-at this time there are 94 of max. 200
230-anonymous users on this server
230-
230-Limits:
230-max. 200 anonymous user
230-max. 2 connection per IP
230-
230-----------------------------------------------------
230-
230 User logged in, proceed.
ftp> ls
200 PORT Command successful.
150 Opening ASCII mode data connection for /bin/ls.
226 Transfer complete.
ftp> dir
200 PORT Command successful.
150 Opening ASCII mode data connection for /bin/ls.
dr--r--r--   1 user     group           0 Feb 12 11:59 .
dr--r--r--   1 user     group           0 Feb 12 11:59 ..
dr--r--r--   

Mozilla displayed:

Index of ftp://ftp.asuscom.de/
pub 		02.12.03 	11:52:00 AM

I'm going to assume from Bradley's comments that this was a server that served
DOS formated directory listings. If anyone knows of another server that acts
like this, I would appreciate a URL.