1315892 - 'text-orientation: upright' should cause all characters to be treated as strong LTR

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Koji Ishii]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161107030203

Steps to reproduce:

5.1. Orienting Text: the text-orientation property states that "This value causes the used value of direction to be ltr, and for the purposes of bidi reordering, causes all characters to be treated as strong LTR."
https://drafts.csswg.org/css-writing-modes-3/#text-orientation

1. Run any of following tests
http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/table-progression-vlr-003/format/html5/
http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/table-progression-vlr-004/format/html5/
http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/table-progression-vrl-003/format/html5/
http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/table-progression-vrl-004/format/html5/


Actual results:

The Test Case tab does not match to the Reference Page tab.


Expected results:

The Test Case tab matches to the Reference Page tab.

Comment 1

[Koji Ishii]

chrome: http://crbug.com/663281

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://github.com/w3c/csswg-drafts/issues/755 says:

Gecko implements partially, by inserting the RLO (the same effect as the workaround above) if the block has text-orientation: upright.

    It has the same restriction as above.
    It does not work when text-orientation: upright is applied to inline elements.
    It does not change the used value of direction, and therefore other effects (e.g., logical properties, table cell orders, etc.) is not included.

Comment 3

[fantasai]

Attachment: patch for layout

This fixes the "used value of direction" aspect for layout (but not style resolution). It passes all reftests on tryserver.

Character-level handling appears to be working as expected, fwiw.

Comment 4

[fantasai]

Attachment: completed patch

Comment 5

[fantasai]

Attachment: Bug 1315892 - 'text-orientation: upright' forces used 'direction' to LTR

Comment 6

[fantasai]

Tryserver run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a79fc1bfc7f8d16c2d5b35c971fa9a36d39fcd84

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8aeda7048e36
'text-orientation: upright' forces used 'direction' to LTR. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/3a8c3658b9a2
Add a comment quoting the spec. r=me

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19070 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8aeda7048e36
https://hg.mozilla.org/mozilla-central/rev/3a8c3658b9a2

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot