132450 - remove unused viewString parameter from OnItemAdded method

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[David :Bienvenu]

This parameter is a left-over from the rdf in the thread pane days - we no
longer need this view parameter.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

Comment on attachment 146089 [details] [diff] [review]
Proposed patch

I changed the first parameter of OnItemAdded/Removed to an nsIRDFResource to
simplify the consumers below.

>+  OnItemRemoved: function(parentItem, item) {
>+    if (parentItem.Value != gCurrentFolderUri)
>       return;
> 
>     var deletedMessageHdr = item.QueryInterface(Components.interfaces.nsIMsgDBHdr);
At this point item could be either a db header or a folder so this could
actually throw an exception. It looks as if it will get ignored but I think
I'll change this anyway.

>+nsresult nsMsgFolderDataSource::OnItemAddedOrRemoved(nsIRDFResource *parentItem, nsISupports *item, PRBool added)
> {
>+  nsCOMPtr<nsIRDFNode> itemNode(do_QueryInterface(item));
>+  if (itemNode)
>+  {
>+    NotifyObservers(parentItem, kNC_Child, itemNode, added, PR_FALSE);
>+  }
>+  return NS_OK;
> }
Again, as item should be either a folder (which will QI to an RDF node) or a db
header (which won't) I didn't think any of the other checks were necessary.

Comment 3

[David :Bienvenu]

Comment on attachment 146089 [details] [diff] [review]
Proposed patch

ok, r=bienvenu with those changes, thx.

Comment 4

[[e-mail]]

Attachment: Fixed possible JS exception

IIRC the exception would be generated if a child folder was deleted while a
message in the parent folder was being displayed standalone.

Comment 5

[[e-mail]]

Fix checked in.

Comment 6

[[e-mail]]

Attachment: Missed some :-[

Comment 7

[[e-mail]]

Comment on attachment 146366 [details] [diff] [review]
Missed some :-[

I hope these last few are simple enough for r/sr.

Comment 8

[David :Bienvenu]

Comment on attachment 146366 [details] [diff] [review]
Missed some :-[

yes, that's fine.

Comment 9

[[e-mail]]

Resolved REALLYFIXED ;-)

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

http://lxr.mozilla.org/seamonkey/search?string=NotifyItemAdded

NotifyItemAdded
/mailnews/addrbook/src/nsAbBSDirectory.cpp, line 74 -- nsresult
nsAbBSDirectory::NotifyItemAdded(nsISupports *item)
/mailnews/addrbook/src/nsAbBSDirectory.cpp, line 147 -- NotifyItemAdded(childDir);
/mailnews/addrbook/src/nsAbBSDirectory.h, line 67 -- nsresult
NotifyItemAdded(nsISupports *item);
/mailnews/addrbook/src/nsAbMDBDirectory.cpp, line 193 -- nsresult
nsAbMDBDirectory::NotifyItemAdded(nsISupports *item)
/mailnews/addrbook/src/nsAbMDBDirectory.cpp, line 677 -- NotifyItemAdded(newList);
/mailnews/addrbook/src/nsAbMDBDirectory.cpp, line 837 -- rv =
NotifyItemAdded(cardSupports);
/mailnews/addrbook/src/nsAbMDBDirectory.cpp, line 981 -- // NotifyItemAdded (card);
/mailnews/addrbook/src/nsAbMDBDirectory.h, line 82 -- NS_IMETHOD
NotifyDirItemAdded(nsISupports *item) { return NotifyItemAdded(item);}
/mailnews/addrbook/src/nsAbMDBDirectory.h, line 116 -- nsresult
NotifyItemAdded(nsISupports *item);
/mailnews/base/public/nsIMsgFolder.idl, line 454 -- void NotifyItemAdded(in
nsISupports item);
/mailnews/base/util/nsMsgDBFolder.cpp, line 868 -- NotifyItemAdded(msgDBHdr);
/mailnews/base/util/nsMsgDBFolder.cpp, line 4025 -- nsresult
nsMsgDBFolder::NotifyItemAdded(nsISupports *item)
/mailnews/imap/src/nsImapMailFolder.cpp, line 934 -- NotifyItemAdded(child);
/mailnews/imap/src/nsImapMailFolder.cpp, line 7260 -- NotifyItemAdded(child);
/mailnews/local/src/nsLocalMailFolder.cpp, line 983 -- NotifyItemAdded(child);
/mailnews/local/src/nsLocalMailFolder.cpp, line 1348 --
parentFolder->NotifyItemAdded(newFolder);
/mailnews/local/src/nsLocalMailFolder.cpp, line 2109 --
NotifyItemAdded(newMsgFolder);
/mailnews/news/src/nsNewsFolder.cpp, line 580 -- NotifyItemAdded(child);