13266 - Mac: Native error dialogs have no icon in them

Status: VERIFIED FIXED

(Core :: Preferences: Backend, defect, P3)

Description

[Simon Fraser [no longer active]]

I just got a native error dialog, by editing my prefs.js file so that it was
malformed (commented a line out with a #). The native error dialog was missing
the normal note, warning or stop icon.

Comment 1

[davidm]

Umm I what does this dialog say? The only native dialog I know of says is the
one checking for 8.6

Comment 2

[Simon Fraser [no longer active]]

It tells me about the JS error. Actually, I think this dialog is coming from the
prefs code.

Comment 3

[davidm]

prefapi.c has a function called pref_Alert which uses kAlertPlainAlert rather
than one with an icon. Other problems include the use of hard coded strings.

Comment 4

[leger]

Moving all libPref component bugs to new Preferences: Backend component.  
libPref component will be deleted.

Comment 5

[Gagan]

->mcafee

Comment 6

[Chris McAfee]

Over to pchen, paul this looks like an easy one-liner, change the dialog
type to an icon type.?

Comment 7

[Simon Fraser [no longer active]]

No, this is very old, and I don't even know if the code is still in libpref to 
show show a native dialog.

Comment 8

[Brian Nesse (gone)]

Bulk assigning bugs covered by the rewrite of nsPrefs to myself.

Comment 9

[Brian Nesse (gone)]

All code accessing this dialog has been removed as part of the work being done as 
part of bug 46863. For that reason, I am marking this as a duplicate of 46863. If 
you feel this is in error, feel free to change it back.


*** This bug has been marked as a duplicate of 46863 ***

Comment 10

[Brian Nesse (gone)]

alecf has requested that I not dupe all these bugs, but rather close them as 
fixed after the work in bug 46863 has landed. Changing again...

Comment 11

[Brian Nesse (gone)]

Platform specific dialogs were removed as part of the preferences refactoring. 
This dialog no longer exists.

Comment 12

[sairuh (rarely reading bugmail)]

okay.