132700 - Editor embedding: nsIEditingSession::MakeEditable should have options for nested iframes

Status: NEW

(Core :: DOM: Editor, defect, P5)

Description

[Simon Fraser [no longer active]]

Currently, nsIEditingSession::MakeEditable() only makes a single <iframe> 
editable. It needs to take a parameter that indicates whether the caller wants 
all nested <iframes> to become editable also (e.g. if loading a frameset page). 
The implementation would look something like:

nsCOMPtr<nsISimpleEnumerator> docShellEnumerator;
docShell->GetDocShellEnumerator( nsIDocShellTreeItem::typeContent,
                                nsIDocShell::ENUMERATE_FORWARDS,
                                getter_AddRefs(docShellEnumerator));  
if (docShellEnumerator)
{
    PRBool hasMore;
    while (NS_SUCCEEDED(docShellEnumerator->HasMoreElements(&hasMore)) && 
hasMore)
    {
        nsCOMPtr<nsISupports> curSupports;
        rv = docShellEnumerator->GetNext(getter_AddRefs(curSupports));
        if (NS_FAILED(rv)) break;

        nsCOMPtr<nsIDocShell> curShell = do_QueryInterface(curSupports, &rv);
        if (NS_FAILED(rv)) break;

        nsCOMPtr<nsIDOMWindow> childWindow = do_GetInterface(curShell,&rv);
        if (childWindow)
            editingSession->MakeWindowEditable(childWindow, PR_FALSE);
    }
}

Comment 1

[dprice (gone)]

giving milestone

Comment 2

[Kathleen :Brade]

changing component so this shows up in Syd's editor embedding queries

Comment 3

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=5 years untouched DOM/Storage bugs' priority.

If you have reason to believe this is wrong (especially for the severity), please write a comment and ni :jstutte.