132705 - nsComponentManagerUtils is wrong

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

We need better error handling.  dbarons has a nice patch.

Comment 1

[Doug Turner (:dougt)]

Attachment: dbaron's patch

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 75509 [details] [diff] [review]
dbaron's patch

I would not worryied about the status from GetComponentManager and just have
status inited to a failure, but I am happy with this.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: slightly cleaner patch

This avoids the NS_SUCCEEDED(status) check if compMgr is non-null.

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 75512 [details] [diff] [review]
slightly cleaner patch

r=dougt

Comment 5

[rpotts (gone)]

Comment on attachment 75512 [details] [diff] [review]
slightly cleaner patch

sr=[e-mail]

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 75512 [details] [diff] [review]
slightly cleaner patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 7

[Doug Turner (:dougt)]

Checking in nsComponentManagerUtils.cpp;
/cvsroot/mozilla/xpcom/glue/nsComponentManagerUtils.cpp,v  <-- 
nsComponentManagerUtils.cpp
new revision: 1.3; previous revision: 1.2
done


dbaron, thank you for the patch.