1330432 - Add prefs to control worker GC timer intervals

Status: NEW

(Core :: DOM: Workers, enhancement, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

We currently hard code GC intervals to:

// JS_MaybeGC will run once every second during normal execution.
#define PERIODIC_GC_TIMER_DELAY_SEC 1

// A shrinking GC will run five seconds after the last event is processed.
#define IDLE_GC_TIMER_DELAY_SEC 5

A one second interval may not be appropriate on slow mobile devices.  See bug 1319278.

I'll add some prefs so we can tune these values.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Expose worker GC timer values as prefs and tune them for fennec. r=baku

Expose worker GC timer values as prefs.  Also, lets slow down how fast we try to GC in mobile as the individual GCs may take longer on slow processors.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=777499dcbf85dc1a9377866ed1ae10f395e66579

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=78148a14224ef6bc4f35c5394fa1c72bbf6aa8d4

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Strangely, this doesn't seem to be working.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

We should consider doing this, but I never had time to figure out what was wrong with these patches.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8826002 [details] [diff] [review]
Expose worker GC timer values as prefs and tune them for fennec. r=baku

This patch doesn't seem to work in my testing.