133277 - give NS_PARSERSERVICE_CID {a6cf9112-15b3-11d2-932e-00805f8add32} a ContractID

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement, P4)

Description

[timeless]

Getting service on shutdown. Denied.
  ContractID: @mozilla.org/observer-service;1
         IID: {d07f5192-e3d1-11d2-8acd-00105a1b8860}
Getting service on shutdown. Denied.
         CID: {a6cf9112-15b3-11d2-932e-00805f8add32}
         IID: {a6cf9111-15b3-11d2-932e-00805f8add32}
Getting service on shutdown. Denied.
  ContractID: @mozilla.org/js/xpc/ContextStack;1
         IID: {a1339ae0-05c1-11d4-8f92-0010a4e73d9a}

Comment 1

[timeless]

Attachment: patch

Comment 2

[harishd]

Comment on attachment 76094 [details] [diff] [review]
patch

r=harishd

Comment 3

[harishd]

--> timeless.

Comment 4

[timeless]

.

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 76094 [details] [diff] [review]
patch

I believe the convention is to append _PREFIX when the contractid is not fully
qualified. So please change NS_PARSER_CONTRACTID to
NS_PARSER_CONTRACTID_PREFIX.

Comment 6

[Kai Engert [:KaiE:]]

It looks like you have checked that in, you might want to mark it fixed.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

*** Bug 129536 has been marked as a duplicate of this bug. ***

Comment 8

[timeless]

Attachment: convert all consumers to use the contract

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 173319 [details] [diff] [review]
convert all consumers to use the contract

r=mrbkap

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 173319 [details] [diff] [review]
convert all consumers to use the contract

sr=bzbarsky

Comment 11

[timeless]

mozilla/embedding/components/find/src/nsFind.cpp 	1.31
mozilla/intl/chardet/src/nsMetaCharsetObserver.cpp 	1.82
mozilla/parser/htmlparser/public/nsIParserService.h 	1.12
mozilla/parser/htmlparser/src/nsParserModule.cpp 	1.56