133503 - [REPRO]Ctrl+F4 active during print preview

Status: RESOLVED FIXED

(Core :: Print Preview, defect, P3)

Description

[[e-mail]]

Using Build ID: 2002032503
Steps to reproduce problem:
1. Press Ctrl+T
2. File/Print Preview
3. Press Ctrl+F4

Actual results: print preview goes blank

Expected results: nothing happens (as per Ctrl+W)

Comment 1

[rods (gone)]

What is <ctrl>F4 suppose to do? 

I checked in a fix on 3/23 for this (general fix) and I cannot reproduce on
Win2k and I verified in the debugger that <ctrl>F4 isn't getting thru.

Comment 2

[[e-mail]]

Ah, the problem only occurs if the focus was in a link/control when you preview.

Comment 3

[Andrew Hagen]

Don't know. Ctrl-F4 can be used to close the current Multiple Document Interface
(MDI) window. Maybe that's like a tab or something.

http://support.microsoft.com/default.aspx?scid=kb;EN-US;q126449

Reporter could you describe all the steps that you follow in order to reproduce
this problem? I didn't understand your last comment.

Comment 4

[[e-mail]]

New steps to reproduce problem:
1. Load up at least two tabs. Load this page in one of them.
2. Click in the Find box at the bottom.
3. File/Print Preview
4. Press Ctrl+F4

Expected result: Nothing happens

Actual result: Print Preview content disappears

Comment 5

[rods (gone)]

I can't reproduce on Win2k

Comment 6

[Andrew Hagen]

Confirming on Build ID: 2002040403 (0.9.9+) Windows 98. This bug could be
limited to Windows 9x.

In browser mode, Ctrl-F4 closes the current tab. In print preview mode, however,
no tabs are shown. Thus, Ctrl-F4 should have no effect.

Steps to reproduce, slightly changed:

1. Open "new" link at the bottom in a new tab. Return to the tab with this page.
2. Click in the Find box at the bottom.
3. File/Print Preview. No tabs are visible.
4. Press Ctrl+F4.

Expected result: Nothing happens.

Actual result: Tab with Print Preview content is dismissed. Browser returns to
the other tab, the "new" page. 

Normal severity. This bug hurts consistency of the UI.

Comment 7

[Andrew Hagen]

Tab control keybindings Ctrl+PgUp and Ctrl+PgDown are also active in print
preview.  See bug description in bug 149907.

Comment 8

[Kevin McCluskey (gone)]

I can reproduce the problem using 2002-6-13 build on WinXP. Ctrl+F4 is active.

nsbeta1-. Not a typical user action while in print preview.

Comment 9

[[e-mail]]

Attachment: Proposed patch

This patch hooks into the handleCtrlPageUpDown attribute set by browser.js

Comment 10

[Paul Gregg]

Confirmed  Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.1a+) Gecko/20020703 SP6a
Almost the same behaviour as mentioned but...
1. Loaded mozilla.org into first tab
2. Loaded this bug into second tab (no other tabs)
3. Selected second tab, clicked on find textfield
4. File-->Print Preview
5. CTRL+F4

Expected result:  Nothing happens

Actual Result:  PP of second tab gone, but replaced with a PP of first tab
(mozilla.org)
Does this mean that when PP a tab, all tabs are actually launched into PP??

Comment 11

[Jesse Ruderman]

See also bug 149907, can switch tabs using keyboard in print preview.

Comment 12

[u60234]

With Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3a) Gecko/20021120 these steps:
1. Open more than one tab
2. Use Print Preview on one of them
3. Press Ctrl+F4 or Ctrl+W

will close the tab that is being print-previewed and show you the remaining tab
with regular screen display but in the Print Preview GUI. The "Close" button
stops working and there seems to be no way to go back to normal browsing mode.

Comment 13

[José Jeria]

Will the proposed patch solve this issue?

Comment 14

[rcummins]

I tried the proposed patch but receive the error "Error launching browser
window:no XBL binding for browser".  This is with Mozilla 1.4, and the patch was
submitted over a year ago...

Comment 15

[[e-mail]]

Attachment: Fixed patch

The previous patch was incorrect. Had it been correct it would have worked with
Mozilla 1.4; as it was changes in Mozilla 1.1 prevented it from applying.

Comment 16

[rcummins]

The new patch works great for me with Mozilla 1.4 on Windows 2000; Ctrl-F4 is
now disabled in Print Preview.  It also fixes bug 149907; after the patch, tabs
are no longer switchable using Ctrl-PgUp/Ctrl-PgDn while print previewing.  Do
you have any magic left for bug 126719 (Ctrl-R or F5 reloads page in PP,
disallowing browsing after PP is closed)?  Thanks!

Comment 17

[jag (Peter Annema)]

Comment on attachment 127670 [details] [diff] [review]
Fixed patch

Hmm, looks like we broke ctrl page-up/down suppression in print preview mode,
if we weren't inheriting handleCtrlPageUpDown (or did it simply never work?)

sr=jag

Comment 18

[[e-mail]]

Comment on attachment 127670 [details] [diff] [review]
Fixed patch

Requesting approval for 1.5

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 127670 [details] [diff] [review]
Fixed patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.5beta.

Comment 20

[[e-mail]]

Fix checked in.