Closed Bug 133801 Opened 22 years ago Closed 22 years ago

nsContentTestNode.cpp breaks 64-bit builds on AIX

Categories

(Core :: XUL, defect)

Other
AIX
defect
Not set
trivial

Tracking

()

VERIFIED FIXED

People

(Reporter: pkwarren, Assigned: hyatt)

Details

(Keywords: 64bit)

Attachments

(1 file)

With the checkin for Bug 118863, content/xul/templates/src/nsContentTestNode.cpp
breaks when building with --enable-debug for 64-bit AIX builds.
pkw:
Can you post the compiler error message that someone can mark this bug as
"confirmed", please ?
Comment on attachment 76460 [details] [diff] [review]
Simple fix - PRInt32->NS_PTR_TO_INT32

Looks OK for me...

r=Roland.Mainz@informatik.med.uni-giessen.de
Attachment #76460 - Flags: review+
Sorry. Here is the error message:

"/home/pkw/mozilla/content/xul/templates/src/nsContentTestNode.cpp", line 96.31:
1540-0216 (S) An expression of type "nsIContent *" cannot be converted to "PRInt32".
gmake[1]: *** [nsContentTestNode.o] Error 1
gmake[1]: Leaving directory
`/home/pkw/mozilla/obj-debug64/content/xul/templates/src'
gmake: *** [all] Error 2
Confirming per comment #4 - thanks!
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 76460 [details] [diff] [review]
Simple fix - PRInt32->NS_PTR_TO_INT32

Easy fix, good enough.	If any 64-bit system needs to log the high 32 bits of a
pointer, this can be changed to use

    aResult += nsPrintfCString("%p", aContext);

or some more efficient formulation using nsPrintfCString.

/be
Attachment #76460 - Flags: superreview+
Nominating for mozilla1.0.

pkw, Thanks for the fix, please mail drivers@mozilla.org asking for approval --
tell them who reviewed, let them know it's <= 0 risk :-).

/be
Keywords: mozilla1.0+
Brendan:

Would your fix be more appropriate in this case? It seems to just be a function
used for debugging, and I would assume printing the entire pointer would be the
desired behavior.
My fix would be purer, but it's late in 1.0 and we don't really care about DEBUG
only potential high-bit of pointer data loss all that much.  Unless you're
really motivated to do the %p thing and get a new patch reviewed and
super-reviewed, I say go for driver approval with what we have here.

/be
Comment on attachment 76460 [details] [diff] [review]
Simple fix - PRInt32->NS_PTR_TO_INT32

a=roc+moz
Attachment #76460 - Flags: approval+
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
.
Status: RESOLVED → VERIFIED
Keywords: 64bit
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: