Closed
Bug 133801
Opened 22 years ago
Closed 22 years ago
nsContentTestNode.cpp breaks 64-bit builds on AIX
Categories
(Core :: XUL, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: pkwarren, Assigned: hyatt)
Details
(Keywords: 64bit)
Attachments
(1 file)
609 bytes,
patch
|
roland.mainz
:
review+
brendan
:
superreview+
roc
:
approval+
|
Details | Diff | Splinter Review |
With the checkin for Bug 118863, content/xul/templates/src/nsContentTestNode.cpp breaks when building with --enable-debug for 64-bit AIX builds.
Reporter | ||
Comment 1•22 years ago
|
||
Comment 2•22 years ago
|
||
pkw: Can you post the compiler error message that someone can mark this bug as "confirmed", please ?
Comment 3•22 years ago
|
||
Comment on attachment 76460 [details] [diff] [review] Simple fix - PRInt32->NS_PTR_TO_INT32 Looks OK for me... r=Roland.Mainz@informatik.med.uni-giessen.de
Attachment #76460 -
Flags: review+
Reporter | ||
Comment 4•22 years ago
|
||
Sorry. Here is the error message: "/home/pkw/mozilla/content/xul/templates/src/nsContentTestNode.cpp", line 96.31: 1540-0216 (S) An expression of type "nsIContent *" cannot be converted to "PRInt32". gmake[1]: *** [nsContentTestNode.o] Error 1 gmake[1]: Leaving directory `/home/pkw/mozilla/obj-debug64/content/xul/templates/src' gmake: *** [all] Error 2
Comment 5•22 years ago
|
||
Confirming per comment #4 - thanks!
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 6•22 years ago
|
||
Comment on attachment 76460 [details] [diff] [review] Simple fix - PRInt32->NS_PTR_TO_INT32 Easy fix, good enough. If any 64-bit system needs to log the high 32 bits of a pointer, this can be changed to use aResult += nsPrintfCString("%p", aContext); or some more efficient formulation using nsPrintfCString. /be
Attachment #76460 -
Flags: superreview+
Comment 7•22 years ago
|
||
Nominating for mozilla1.0. pkw, Thanks for the fix, please mail drivers@mozilla.org asking for approval -- tell them who reviewed, let them know it's <= 0 risk :-). /be
Keywords: mozilla1.0+
Reporter | ||
Comment 8•22 years ago
|
||
Brendan: Would your fix be more appropriate in this case? It seems to just be a function used for debugging, and I would assume printing the entire pointer would be the desired behavior.
Comment 9•22 years ago
|
||
My fix would be purer, but it's late in 1.0 and we don't really care about DEBUG only potential high-bit of pointer data loss all that much. Unless you're really motivated to do the %p thing and get a new patch reviewed and super-reviewed, I say go for driver approval with what we have here. /be
Comment on attachment 76460 [details] [diff] [review] Simple fix - PRInt32->NS_PTR_TO_INT32 a=roc+moz
Attachment #76460 -
Flags: approval+
Comment 11•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•