134013 - XSLT forbids VariableReference in templates and keys

Status: NEW

(Core :: XSLT, defect)

Description

[gary.frederick]

The template rule 
  <xsl:template match="item[position() mod $thisnup = 1]">
should generate an error because the match attribute has a variable in it.
  http://www.w3.org/TR/xslt#section-Defining-Template-Rules

I like that it does not generate an error. The variable can be resolved at
runtime and the expression with the variable gives me a way to generate
different results, based on the value at runtime.

But it is not correct...

Gary

Attachments in a bit

Comment 1

[gary.frederick]

Attachment: xslt stylesheet with the non standard template rule

Comment 2

[gary.frederick]

Attachment: xml file that uses the xslt file

Comment 3

[gary.frederick]

Attachment: data for the stylesheet

Comment 4

[gary.frederick]

Attachment: xslt stylesheet with the non standard template rule

pointed to the data.xml file

Comment 5

[gary.frederick]

Attachment: xsl file that ponts to the corrected xslt file

obsoletes 76602
and
76608 obsoletes 76597

Comment 6

[Axel Hecht]

bah. same goes for xsl:key match pattern and use expression.
Sounds like ExprParser needs beat-a-jonas-state-for-this.

Comment 7

[Axel Hecht]

Attachment: stylesheet ,VariableReference in xsl:template/@match

Comment 8

[Axel Hecht]

Attachment: on-click, testcase VariableReference in xsl:template/@match

Comment 9

[Axel Hecht]

gary reported this to xalan, too 
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7603

Comment 10

[Axel Hecht]

test for keys coming up (topic corrected).
Wow, that beast crashes on me at a thousand places. But only in module.
And I gave up on gdb on solaris for good right now, somebody with a real
compiler/debugger suite should try.

Comment 11

[Axel Hecht]

Attachment: stylesheet, testcase xsl:key/@match

Comment 12

[Axel Hecht]

Attachment: one-click xml, testcase xsl:key/@match

testcase for xsl:key/@match, I won't generate a third one for @use.
You get the idea, huh?

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** Bug 344374 has been marked as a duplicate of this bug. ***

Comment 14

[Peter Van der Beken [:peterv]]

Attachment: v1

Applies on top of attachment 412476 [details] [diff] [review].

Comment 15

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't see code that would make

aContext->allowed(txIParseContext::VARIABLE_REFERENCE)

return false. Am I missing something?

Comment 16

[Peter Van der Beken [:peterv]]

Comment on attachment 412477 [details] [diff] [review]
v1

No, you're right. Something got lost when splitting up the patches.