134165 - nsHttpHandler uses nsXPIDLCString for no apparent reason

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Almost all string members of nsHttpHandler are nsXPIDLCStrings, even though at
least some of them are never used in IDL calls; they are only assigned to.
Also, these strings are assigned to using .Adopt(nsCRT::strdup(...));

This could be made much faster if nsCAutoString and .Assign would be used.

This is true for at least these two members:
mPlatform mOscpu

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Other members which can be changed:
mAppname
mAppVersion
mPlatform
mLanguage

And the others should probably use .Assign too, instead of .Adopt

Comment 2

[Darin Fisher]

the reason stems from the fact that many of the UA components are set via
preferences, and we use getter_Copies to get string values from prefs.

of course, not all string values are set via prefs as you've noticed.  using
nsCAutoString here is wasteful since the values are member variables, and
allocation of the UA components is only done really once during startup.

this is hardly a significant issue, but it probably should be cleaned up.

Comment 3

[Mikael Parknert]

Attachment: patch

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 172011 [details] [diff] [review]
patch

hm... can you make the variable names align with the other ones? compare
mUserAgent.

r=biesi with that change; please attach a new patch with it

Comment 5

[Mikael Parknert]

Attachment: updated with indent

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 172039 [details] [diff] [review]
updated with indent

thanks

Comment 7

[Darin Fisher]

Comment on attachment 172039 [details] [diff] [review]
updated with indent

sr=darin

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

I checked this patch in:
Checking in netwerk/protocol/http/src/nsHttpHandler.h;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpHandler.h,v  <--  nsHttpHandler.h
new revision: 1.44; previous revision: 1.43
done

Comment 9

[benc]

V. lxr.