134304 - SOCKS V4 pref from 4.7x migration isn't used.

Status: RESOLVED WONTFIX

(Core :: Networking, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: 2002-03-28-03, Windows 2000.

Summary: SOCKS V4 pref from 4.7x migration isn't used.

Steps to Reproduce:

1. Create a 4.7x profile that includes a manual (not PAC) SOCKS V4 preference. 
In my case, this is 'jubertix.office.aol.com', on port 1080.
2. Launch 6.x and wait for the conversion to take place.
3. Connect to any networking protocol, and view netstat output.

Expected Results:

netstat: jubertix.office.aol.com:1080 ESTABLISHED

as well as:

Edit | Preferences | Advanced | Proxies | Manual proxy configuration with a
value of:

jubertix.office.aol.com and port 1080 in the SOCKS Host field.

Actual Results:

In the copied over prefs.js, I have:

user_pref("network.hosts.socks.server", "jubertix.office.aol.com");
user_pref("network.proxy.type", "1")

When I go to Edit | Preferences | Advanced | Proxies, I see:

The radio button for the following is enabled:

Manual Proxy Configuration

but no values exist in the SOCKS Host or Port textfields.

Now, I realize that 4.7x doesn't contain SOCKS V5 support, so shouldn't 6.x
assume that whatever value imported from 4.7x is indeed a V5 value?

Comment 1

[Bradley Baetz (:bbaetz)]

Mozilla uses network.proxy.socks and network.proxy.socks_port, and defaults to
socks 5.

Rather than suppoting a new pref, maybe profile miogration should be able to do
this?

-> default owner, sorry.

Comment 2

[benc]

There is no attribute mapping in profile migration.

There is a file copy of the old profile into the new profile directory.

Comment 3

[benc]

cc: grace for profiles.

Comment 4

[Bradley Baetz (:bbaetz)]

Ah, ok. Hmm

Then we have a problem: the default socks version is 5 for backwards
compatability with older mozilla versions, before there was a choice.

But with ns4, we need to default to version 4.

Is there a way we can find out if the profile was migrated? Then necko could
write out the pref if it discovered that it was missing. Otherwise we have to
guess...

Comment 5

[benc]

I suggest we try two things:

1- Adding Sarah, b/c she is the actual prefs QA, and can probably truly verify
this. 

2- You could (and I don't know if this is politically correct or not), do
something like:

if "network.hosts.socks.server" exists, then (read values into
"network.proxy.socks and network.proxy.socks_port"; unset
""network.hosts.socks.server"; and set SOCKS type to 4").

I think these should be part of the migration event, but it could also happen
somewhere else (possibly in Necko?)

Ugh.

Comment 6

[Bradley Baetz (:bbaetz)]

Hmm. Yeah, we could do this in the nsProtocolProxyService code. I didn't thikn
of basing this off the other pref.

Comment 7

[benc]

-> Future, to focus on other bugs for now.

bbaetz: send it back if you think this is doable for 1.0.

Comment 8

[benc]

The main attributes are fixed in the newer migration stuff:

http://lxr.mozilla.org/mozilla/source/browser/components/migration/src/nsDogbertProfileMigrator.cpp#412

However, we need to set the socks version explicitly to v4.

network.proxy.socks_version

http://www.mozilla.org/quality/networking/docs/netprefs.html

Comment 9

[Matthias Versen [:Matti]]

Netscape4 profile migration is no longer supported