134935 - Collapse and Expand in History context menu share the same accesskey entry

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Jaagup Irve]

Mozilla/5.0 (Windows; U; Win98; et-EE; rv:0.9.9+) Gecko/20020401

The history window (CTRL+H) has a menu item in its popup menu that enables the
user to expand and collapse history groups. Both entries - Collapse and Expand -
share the same accesskey ( collapseExpand.accesskey ), making them difficult to
localize.

Accesskey is in:
/xpfe/components/history/resources/locale/en-US/historyTreeOverlay.dtd

Note that very similar, yet unused entry is located in:
/xpfe/components/history/resources/locale/en-US/history.properties

Since the entry label is created dynamically in history.js it could be easy to
fix this one.

1. remove both collapseExpand entries from .dtd and .properties.
2. add two new entries to .dtd - collapseLabel.accesskey and expandLabel.accesskey
3. on line 415 in history.js update the if-clause to, in addition to changing
the strings, also change the corresponding accesskey entries.

Comment 1

[Frank Tang]

how to execute this access key, I bring up the history window and press e or
control+e on window and nothing happened. add [e-mail] here because
the cvsblame show he is the one who create these files. 

Comment 2

[Jaagup Irve]

Select View->Group by->Date

And then right-click on some domain group. The first menu item is the 
CollapsE/Expand one.

Comment 3

[Kenneth Herron]

Confirming. Both collapse and expand use the same access key. Access keys are
subject to change in locallized versions, so this could be awkward in some
languages.

Comment 4

[piers]

Attachment: Seperate accesskeys for Expand and Collapse

Seperate the accesskeys for localisation and make it _C_ollapse and _E_xpand.

Comment 5

[:deanis74]

Comment on attachment 113797 [details] [diff] [review]
Seperate accesskeys for Expand and Collapse

Don't we usually store accesskeys in the .dtd and not in .properties?  Or does
the changing of this on-the-fly dictate that it must be in a string bundle in
.properties?

Comment 6

[piers]

Yeah, you can't access dtd entities from js.

cc'ing aaronl for access.

Comment 7

[:deanis74]

Comment on attachment 113797 [details] [diff] [review]
Seperate accesskeys for Expand and Collapse

Is 'X' available for Expand?  That makes more sense to me than 'E'.

Comment 8

[piers]

Attachment: Seperate accesskeys for Expand and Collapse v2

per comment 7. Sounds good to me.

Comment 9

[:deanis74]

Comment on attachment 114031 [details] [diff] [review]
Seperate accesskeys for Expand and Collapse v2

Me likey.  r=me

Comment 10

[OOO until Jun 29 - Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 114031 [details] [diff] [review]
Seperate accesskeys for Expand and Collapse v2

sr=dmose.  Sorry i took so long on this.

Comment 11

[Robert Kaiser]

Checking in
mozilla/xpfe/components/history/resources/locale/en-US/history.properties;
/cvsroot/mozilla/xpfe/components/history/resources/locale/en-US/history.properties,v
 <--  history.properties
new revision: 1.5; previous revision: 1.4
done
Checking in
mozilla/xpfe/components/history/resources/locale/en-US/historyTreeOverlay.dtd;
/cvsroot/mozilla/xpfe/components/history/resources/locale/en-US/historyTreeOverlay.dtd,v
 <--  historyTreeOverlay.dtd
new revision: 1.6; previous revision: 1.5
done
Checking in mozilla/xpfe/components/history/resources/history.js;
/cvsroot/mozilla/xpfe/components/history/resources/history.js,v  <--  history.js
new revision: 1.55; previous revision: 1.54
done
Checking in mozilla/xpfe/components/history/resources/historyTreeOverlay.xul;
/cvsroot/mozilla/xpfe/components/history/resources/historyTreeOverlay.xul,v  <--
 historyTreeOverlay.xul
new revision: 1.33; previous revision: 1.32
done

I checked in for [e-mail], fixed.