1350466 - Uplift bug 1342832 to bmo for performance and other reasons

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

prior to loading the cpan meta configuration file ("MYMETA.json") setting the env PERL_JSON_BACKEND to JSON::XS will result in a significant performance boost

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1350466_2.patch

Issues this fixes:

1) Parsing MYMETA.json every request with pure-perl JSON takes a long time.
    Much better to JSON::XS.
2) Fixes bug where in one code path the CPAN::Meta object is stored in the request cache, and another the process cache. Now it's just a proper file scoped lexical. 

The other changes are for concerns of upstream -- I don't want this logic to diverge too far.

The main negative is that checksetup.pl fails if the local/ directory isn't populated. This is because we run on 5.10 (upstream requires 5.14 and this doesn't happen then). This is actually a *feature* because it lets us know very early that a system is broken. (We had local/ disappear on a server recently and it was not immediately obvious).

As I don't expect you to run this, I am functional-testing it on bugzilla-dev.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1350466_3.patch

Failed pod checker. fixed.

Comment 3

[:glob ✱]

Comment on attachment 8851305 [details] [diff] [review]
1350466_3.patch

Review of attachment 8851305 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob lgtm

Comment 4

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   08c0187..15daaf1  master -> master