Closed Bug 1351959 Opened 7 years ago Closed 7 years ago

Get skip-waiting service worker WPT tests passing

Categories

(Core :: DOM: Service Workers, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We have a number of WPT tests disabled and marked as failing for skip-waiting.  We should figure out what the problem is there since that is a stable feature.

Some of these tests were recently disabled in bug 1347497.
These tests were all broken by request-end-to-end.https.html using an infinitely blocking waitUntil() is its service worker.  Since it uses the super generic 'resources/blank.html' this affects a number of tests that follow it in the execution order.

I largely worked around this issue by moving these tests all to unique scopes instead.  I also asked the upstream author to fix here:

https://github.com/w3c/web-platform-tests/pull/4879/files#r108851542

Try build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8b01c090189c5aa37f35629425cc45f0c449dcf
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Attachment #8852796 - Flags: review?(bugmail)
Attachment #8852796 - Flags: review?(bugmail) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd77b16f22cc
Fix skip-waiting and other WPT tests broken by request-end-to-end.https.html. r=asuth
https://hg.mozilla.org/mozilla-central/rev/bd77b16f22cc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: