Closed
Bug 135547
Opened 23 years ago
Closed 23 years ago
make event queues more robust
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
(Whiteboard: [adt2])
Attachments
(1 file)
|
1.30 KB,
patch
|
danm.moz
:
review+
brendan
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
make event queues more robust
|
Assignee | |
Comment 1•23 years ago
|
||
same patch i sent out this morning... i think this patch would help close up
some potential holes in the event queue impl. it might solve the modal dialog
problem brendan observed.
Comment on attachment 77745 [details] [diff] [review]
v1 patch
I'll bite. I think it's a good change.
Attachment #77745 -
Flags: review+
|
|
Assignee | |
Updated•23 years ago
|
Severity: normal → major
Status: NEW → ASSIGNED
Keywords: mozilla1.0,
nsbeta1
Priority: -- → P1
Target Milestone: --- → mozilla1.0
seems like a safe thing to do.
|
|
||
Comment 4•23 years ago
|
||
Comment on attachment 77745 [details] [diff] [review]
v1 patch
I trust there's no need to loop (while rather than if in the nsEventQueue.cpp
patch). sr=brendan@mozilla.org.
/be
Attachment #77745 -
Flags: superreview+
|
|
Assignee | |
Comment 5•23 years ago
|
||
yes, a loop should be unnecessary since a queue that has mStopAccepting set to
TRUE will not accept any more events on PostEvent (new events will be punted to
the elder queue).
|
||
Comment 6•23 years ago
|
||
Comment on attachment 77745 [details] [diff] [review]
v1 patch
a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #77745 -
Flags: approval+
|
|
||
Comment 7•23 years ago
|
||
|
|
||
Comment 8•23 years ago
|
||
We want this for mozilla1.0's RC1, I think.
/be
Keywords: mozilla1.0 → mozilla1.0+
|
|
Assignee | |
Comment 9•23 years ago
|
||
yes, i agree... i'm just waiting for ADT approval at this point.
|
|
||
Comment 10•23 years ago
|
||
adt1.0.0+ (on behalf of the adt)
|
|
Assignee | |
Comment 11•23 years ago
|
||
fixed-on-trunk
fixed-on-branch
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
|
||
Updated•23 years ago
|
QA Contact: madhur → rakeshmishra
|
||
Comment 12•23 years ago
|
||
Nit:
removing is spelt wrong in the comments (nsEventQueueService.cpp)
|
|
||
Comment 13•23 years ago
|
||
confirmig the check in at Rakesh Mishra's request.
|
|
||
Comment 14•23 years ago
|
||
verifying as per comment #13 From Alexandru Savulov
Status: RESOLVED → VERIFIED
|
|
||
Comment 15•23 years ago
|
||
adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.
Keywords: fixed1.0.0
|
||
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•