135721 - nss_ckmdSessionObject_GetAttribute should return NSSCKFWItem

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Wan-Teh Chang]

This is unfinished work of bug 134095 and was reported by Nelson.

The compiler warns when compiling lib/ckfw/sessobj.c:

cc -o SunOS5.8_64_DBG.OBJ/sessobj.o -c -g -KPIC -DSVR4 -DSYSV -D__svr4
-D__svr4__ -DSOLARIS -D_REENTRANT -DSOLARIS2_8 -D_SVID_GETTOD -xarch=v9 -xs
-DXP_UNIX -DDEBUG -UNDEBUG -DDEBUG_svbld -I/usr/dt/include
-I/usr/openwin/include -I../../../../dist/SunOS5.8_64_DBG.OBJ/include
-I../../../../dist/public/security -I../../../../dist/private/security
-I../../../../dist/public/security -I../../../../dist/public/nspr  sessobj.c

"sessobj.c", line 305: warning: assignment type mismatch:

This is because after the fix for bug 134095,
nss_ckmdSessionObject_GetAttribute should return NSSCKFWItem
as opposed to const NSSItem *.

Comment 1

[Julien Pierre]

Fixed on the tip in 
Repository revision: 1.9     /cvsroot/mozilla/security/nss/lib/ckfw/sessobj.c,v

Comment 2

[Wan-Teh Chang]

I added back the 'static' qualifier on the forward declaration
that was accidentally deleted.

Checking in sessobj.c;
/cvsroot/mozilla/security/nss/lib/ckfw/sessobj.c,v  <--  sessobj.c
new revision: 1.10; previous revision: 1.9
done

Comment 3

[Wan-Teh Chang]

I merged the fix on the NSS_3_4_BRANCH.