Closed
Bug 135728
Opened 23 years ago
Closed 23 years ago
Fixes for three benign compiler warnings
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.4.1
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
1.26 KB,
patch
|
bugz
:
review+
|
Details | Diff | Splinter Review |
In stanpcertdb.c, a function declared as returning SECStatus
returns PR_FAILURE. Since SECFailure and PR_FAILURE both
are enumeration constants with the same value (-1), this is
not a problem.
In pk11pars.c, the functions STAN_AddModuleToDefaultTrustDomain
and STAN_RemoveModuleFromDefaultTrustDomain are not declared.
Since these two functions return SECStatus (an enumeration type),
I believe it is not a problem for the compiler to implicitly
declare them as returning int.
I will attach a patch.
|
Assignee | |
Comment 1•23 years ago
|
||
|
||
Comment 2•23 years ago
|
||
Comment on attachment 77866 [details] [diff] [review]
Proposed patch
looks good to me.
Attachment #77866 -
Flags: review+
|
|
Assignee | |
Comment 3•23 years ago
|
||
Fix checked into the tip. Thanks for the code review, Ian.
Status: NEW → RESOLVED
Closed: 23 years ago
Priority: -- → P2
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•23 years ago
|
||
Fix has been merged on the NSS_3_4_BRANCH, just to be safe.
Target Milestone: --- → 3.4.1
You need to log in
before you can comment on or make changes to this bug.
Description
•