Closed Bug 135808 Opened 22 years ago Closed 22 years ago

STAN_GetDefaultCryptoToken() leaks a slot reference

Categories

(NSS :: Libraries, defect, P1)

Product:
NSS
Component:
Libraries
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wtc, Assigned: bugz)

References

Details

(Whiteboard: [adt2 RTM])

Attachments

(1 file, 1 obsolete file)

remove this function
581 bytes, patch
rrelyea
: review+
Details | Diff | Splinter Review 
STAN_GetDefaultCryptoToken() in pki3hack.c calls
PK11_GetInternalSlot() but does not free the slot
reference.
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee
Attached patch Proposed patch (obsolete) — — Splinter Review 
Ian,

I am not sure if this is really a slot reference leak.
If it is, this patch should fix the leak.
Assigned the bug to Ian.
Assignee: wtc → ian.mcgreer
Priority: -- → P1
Target Milestone: --- → 3.5
There are no longer any callers of this function.  It was originally (3.4) used
to get an NSSToken to do hashing operations on.  This has been replaced by
PK11_GetInternalSlot/PK11_FreeSlot (see devtoken.c).

Therefore, I propose to remove it entirely.
Attachment #82953 - Attachment is obsolete: true
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment on attachment 82962 [details] [diff] [review]
remove this function

Not only is the patch obvious, if there is anything wrong with the patch the
linker will tell us immediately:).

bob
Attachment #82962 - Flags: review+
Blocks: 145836
adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch. Pls check this in
asap. thanks!
Keywords: adt1.0.1+, mozilla1.0.1, nsbeta1+
Whiteboard: [adt2 RTM]
Keywords: adt1.0.1+, mozilla1.0.1 → fixed1.0.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: