Closed Bug 135862 Opened 22 years ago Closed 22 years ago

"New Composer Page" menuitem is missing from Composer menus

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: cmanske, Assigned: Brade)

Details

(Whiteboard: [adt2]EDITORBASE)

Attachments

(2 files, 2 obsolete files)

Updated patch for strings
1.82 KB, patch
Brade
: review+
kinmoz
: superreview+
jesup
: approval+
Details | Diff | Splinter Review
patch v2 to restore menuitem
1.60 KB, patch
Brade
: review+
kinmoz
: superreview+
jesup
: approval+
Details | Diff | Splinter Review 
Blake recently changed menus according to new spec for bug 108099, and removed
the app-specific "New" item from each File menu. But he did not move it into
the "New" submenu, so we have no menuitem for "New".
Patch comming. Assigning to brade to checkin, since I'm going on vacation.
Keywords: adt1.0.0, nsbeta1
Whiteboard: [adt2]EDITORBASE, FIX IN HAND ,need sr=
Target Milestone: --- → mozilla1.0
Attached patch patch v1 (obsolete) — — Splinter Review 

    
    

    
  
There may be other problems with "New" submenu in Composer. Shouldn't the 
"Navigator Window" be the second item, not the last?
And now that I think about it, the wording of the Composer item really shouldn't 
be "New Composer Page" now that it's in the "New" submenu.
Other modules use "Blank Page to Edit". Is that what we should use now ?


    
    

    
  
Comment on attachment 77979 [details] [diff] [review]
patch v1

r=brade this is a minimal fix which we have must have

        Attachment #77979 -
        Flags: review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        String change for menuitem (obsolete)
        — 
          — Splinter Review
      

    


  
We shouldn't include "New" in menuitem that is the "New" submenu

    
    

    
  
Neil, Andrew: Could you help fix the order of items problem in Composer
"New" submenu? Thanks.


    
    

    
  


  
This changes the strings so they are the same in all modules

    
  

        Attachment #77982 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 77985 [details] [diff] [review]
Updated patch for strings

r=brade

        Attachment #77985 -
        Flags: review+

    
    

    
  


  
Same as before, but add <menuseparator> under "Composer Page" item

        Attachment #77979 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 77991 [details] [diff] [review]
patch v2 to restore menuitem

r=brade

        Attachment #77991 -
        Flags: review+

    
    

    
  
Comment on attachment 77991 [details] [diff] [review]
patch v2 to restore menuitem

sr=kin@netscape.com

        Attachment #77991 -
        Flags: superreview+

    
    

    
  
Comment on attachment 77985 [details] [diff] [review]
Updated patch for strings

sr=kin@netscape.com

        Attachment #77985 -
        Flags: superreview+

    
    

    
  
Comment on attachment 77991 [details] [diff] [review]
patch v2 to restore menuitem

looks good to me. -andreww

    
    

    
  
adt1.0.0+ (on ADT's behalf) approval for checkin in to 1.0. Pls check this in now.
Keywords: adt1.0.0 → adt1.0.0+

    
    

    
  
Comment on attachment 77991 [details] [diff] [review]
patch v2 to restore menuitem

a=rjesup@wgate.com

        Attachment #77991 -
        Flags: approval+

    
    

    
  
fix checked in
Status: NEW → RESOLVED
Closed: 22 years ago
OS: Windows 2000 → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [adt2]EDITORBASE, FIX IN HAND ,need sr= → [adt2]EDITORBASE

    
    

    
  
verified in 4/10 build.
Status: RESOLVED → VERIFIED

    
    

    
  
reopen bug; part of the patch was not checked in
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

    
    

    
  
In the first patch, there are some string changes to utilityOverlay.dtd which
didn't get checked in.

mcarlson--is it too late to land this on the branch?
Status: REOPENED → ASSIGNED

    
  
Keywords: nsbeta1 → nsbeta1+

    
    

    
  
Ray - Can you answer on mcarlson behalf?

    
    

    
  
l10n approved for check in. 

    
    

    
  
fix checked into trunk and branch

QA: please verify that all components use "Composer Page" instead of "Blank Page
to Edit" (where the option to create a new composer page exists)
Status: ASSIGNED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED

    
    

    
  
Verified on 04-16 trunk, and 04-15 1.0.0 branch.
Status: RESOLVED → VERIFIED
Keywords: verified1.0.0

    
  
Keywords: fixed1.0.0
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: