Closed Bug 1359991 Opened 7 years ago Closed 7 years ago

2.61ms uninterruptible reflow at onxblmousedown@chrome://browser/content/tabbrowser.xml:7392:11

Categories

(Firefox :: Tabbed Browser, enhancement, P1)

Product:
Firefox
Component:
Tabbed Browser
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 58
Project Flags:
Performance Impact medium
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: marco, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ohnoreflow][reserve-photon-performance])

Attachments

(1 file)

Don't flush here
953 bytes, patch
mconley
: review+
Details | Diff | Splinter Review 
Here's the stack:

onxblmousedown@chrome://browser/content/tabbrowser.xml:7392:11
Component: Untriaged → Tabbed Browser
Flags: qe-verify?
Priority: -- → P2
          this.clientTop; // just using this to flush style updates
http://searchfox.org/mozilla-central/rev/ce5ccb6a8ca803271c946ccb8b43b7e7d8b64e7a/browser/base/content/tabbrowser.xml#7391

This is on the mousedown event handler of the tabbrowser-tab binding, when clicking the currently selected tab.
Blocks: 462289
Whiteboard: [ohnoreflow][qf][photon-performance] → [ohnoreflow][qf:p1][photon-performance]
Flags: qe-verify? → qe-verify-
Priority: P2 → P3
Whiteboard: [ohnoreflow][qf:p1][photon-performance] → [ohnoreflow][qf:p1][reserve-photon-performance]
Whiteboard: [ohnoreflow][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:p2][reserve-photon-performance]
Priority: P3 → P4
Attached patch Don't flush here — — Splinter Review 
I don't see any issue on Linux when I remove this line. Perhaps 743877 made this unnecessary.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #8910808 - Flags: review?(mconley)
Priority: P4 → P1
Comment on attachment 8910808 [details] [diff] [review]
Don't flush here

Review of attachment 8910808 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8910808 - Flags: review?(mconley) → review+
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1f5ab037fb6
remove flush when clicking tab, r=mconley
https://hg.mozilla.org/mozilla-central/rev/e1f5ab037fb6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Performance Impact: --- → P2
Whiteboard: [ohnoreflow][qf:p2][reserve-photon-performance] → [ohnoreflow][reserve-photon-performance]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: