1364277 - dom/workers/tests/serviceworkers/test_controller.html races service worker state

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

The test in:

  dom/workers/tests/serviceworkers/test_controller.html

Doesn't wait for the service worker registration to activate at all.  It has been relying on an empty service worker script just being really fast.

My patches in bug 1293277 trigger this more frequently, so I need to fix it.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Make test_controller.html wait for service worker activation. r=asuth

Similar to bug 1364276, this is another test where we just don't wait for the service worker activate.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a669b02d57fa679d06976348c78dea48566e36

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Wait for service workers to activate more in dom/workers/test/serviceworkers. r=asuth

It turned out there were more issues like this in dom/workers/test/serviceworkers.  So I added a waitForState() helper and tried to use it everywhere it seemed like it could help.

This directory has a lot of tests that use a pattern where an iframe is created and the ready promise in the iframe signals activation.  I tried not to duplicate with this technique, but I think in some cases I did.  This should not cause a problem, though.  In general I think waiting for a consistent state would be more predictable.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df5a83b973e01c07e1bc4ea4afd2878e05b57454

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8867427 [details] [diff] [review]
Wait for service workers to activate more in dom/workers/test/serviceworkers. r=asuth

Sorry for the flag spam.  I missed at least one more test here.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Wait for service workers to activate more in dom/workers/test/serviceworkers. r=asuth

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac32aed900c18ef7d9e15b3420053bf22442bf70

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8867429 [details] [diff] [review]
Wait for service workers to activate more in dom/workers/test/serviceworkers. r=asuth

Ok, both my client patches and the try server are happy with this now.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8867429 [details] [diff] [review]
Wait for service workers to activate more in dom/workers/test/serviceworkers. r=asuth

Review of attachment 8867429 [details] [diff] [review]:
-----------------------------------------------------------------

Lots of good cleanup in here!  (And it's a little amusing that the XSLT test had the "best" wait-for-activation logic, it just hadn't been factored out into a helper.)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b38af5ceaae5
Wait for service workers to activate more in dom/workers/test/serviceworkers. r=asuth

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b38af5ceaae5