1364285 - Cache user settings in memcached (extracted from bug 1021795)

Status: RESOLVED INCOMPLETE

(bugzilla.mozilla.org :: General, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

Attachment: user_settings_cache_1.patch

Carrying forward dkl's r+ from bug 1021795

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8867028 [details] [diff] [review]
user_settings_cache_1.patch

I would feel bad just pushing this forward based on the very old review. Can you provide a quick sanity check? I think maybe we should be clearing this cache key explicitly.

Comment 2

[:glob ✱]

Comment on attachment 8867028 [details] [diff] [review]
user_settings_cache_1.patch

Review of attachment 8867028 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/User/Setting.pm
@@ +179,3 @@
>      my $dbh = Bugzilla->dbh;
>  
> +    my $cache_key = "user_settings_all.$user_id";

clear_settings_cache() needs its cache_key updated too

@@ +180,5 @@
>  
> +    my $cache_key = "user_settings_all.$user_id";
> +    my $settings = Bugzilla->memcached->get_config({ key => $cache_key });
> +    return $settings if $settings;
> +    

whitespace

@@ +186,5 @@
> +        q{SELECT name, default_value, is_enabled, setting_value, subclass, category
> +            FROM setting
> +    LEFT JOIN profile_setting
> +                ON setting.name = profile_setting.setting_name
> +                AND profile_setting.user_id = ?}, undef, ($user_id));

indentation of the LEFT JOIN line needs fixing