136659 - Use shading or color to differentiate the active tab more clearly from the other three tabs.

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect, P2)

Description

[Sean Cotter]

Our recent usability test showed that users frequently have difficult
identifying which tab is currently selected.

Therefore, we'd like to make the active tab stand out more. One possible
solution, based on the way normal tabs work in the rest of the interface, would
be to make all the tabs except the selected one darker.

Comment 1

[Sean Cotter]

nominating for nsbeta1+

Comment 2

[Terri Preston]

Agreed, would be nice to have, marking new

Comment 3

[Luke Koleszar]

Dupe of bug 109607?

Comment 4

[Sean Cotter]

No, this is not a dupe of 109607. That bug has to do with regular tabs (not
sidebar-style tabs) in the Classic theme. 

This bug has to do with changing the appearance of just the sidebar-style tabs
in the Help window. It has nothing to do with regular tabs and it is confined to
the Help window--I'm not proposing a global change to all sidebar-style tabs.

Comment 5

[scottputterman]

Lowering to adt3. 

Comment 6

[rudman]

Marking for rtm.

Comment 7

[rudman]

nsbeta1+, per usability.

Comment 8

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 9

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 10

[robinf]

changing keyword to nominate for next release.

Comment 11

[robinf]

marking nsbeta1+ for Buffy.

Comment 12

[robinf]

Upgrading to P2.

Comment 13

[Ian Oeschger (gone)]

Working on this now. ACCEPTING. The sidebar skin stuff I am stealing to style
these pseudo sidebar tabs is keyed off of the selected attribute (e.g,
.box-texttab[selected]), but I am using hidden="false" to show and hide the
different tabs. Plus sidebar styles have been updated in general: background is
darker, new images on the top, etc.

Comment 14

[Ian Oeschger (gone)]

Attachment: setting background color properly on whole sidebar

need to start with this update: the background color of sidebars has changed in
Modern underneath the Help window. This gets the Help sidebar in line. Then I
can do the rules for distinguishing the selected tab.

Comment 15

[Ian Oeschger (gone)]

Andrew -- When you drag yourself into work this morning, can you r=andrew this
for me? It's just catching the Help window up to the current bgcolor for
sidebars. tanks!

Comment 16

[andreww]

Comment on attachment 100410 [details] [diff] [review]
setting background color properly on whole sidebar

it's hard to review this bug when I cant see any lines of context... could you
do a diff with some lines above and below it?

Comment 17

[andreww]

Comment on attachment 100410 [details] [diff] [review]
setting background color properly on whole sidebar

r=andreww

Comment 18

[Ian Oeschger (gone)]

checked in a recoloring of the sidebar background from patch. keeping this open
for highlighting active tab.

Comment 19

[Ian Oeschger (gone)]

moving stuff over to an outside-the-firewall email for the time being, looking
for people to pick these Help and doc bugs up for me.

Comment 20

[R.J. Keller]

mass reassign of all of Ian Oeschger's bugs to me (R.J. Keller).

Comment 21

[R.J. Keller]

Attachment: Patch

Makes the selected sidebar tab highlighted like in Seamonkey.

Comment 22

[R.J. Keller]

Comment on attachment 131373 [details] [diff] [review]
Patch

jag, can I get a r/sr from you?

Comment 23

[[e-mail]]

Comment on attachment 131373 [details] [diff] [review]
Patch

>Index: resources/content/help.js
>===================================================================
>RCS file: /cvsroot/mozilla/extensions/help/resources/content/help.js,v
>retrieving revision 1.44
>diff -u -r1.44 help.js
>--- resources/content/help.js	11 Jun 2003 17:45:30 -0000	1.44
>+++ resources/content/help.js	13 Sep 2003 01:58:24 -0000
Sadly you forgot to fix lines 94-96 :-(

>+	       emptySearchText = getAttribute(helpFileDS, panelDef, NC_EMPTY_SEARCH_TEXT, null) || "No search items found." ;
Nit: take out the space before the ; too.

Comment 24

[R.J. Keller]

Attachment: Patch with Neil's comments

> Sadly you forgot to fix lines 94-96 :-(
hmm. Don't know how that change disappeared from my patch. Must've accidentally
deleted it when cleaning up the garbage that diff created. Sorry about that! I
made sure that I didn't accidentally delete any other vital parts of the patch.

Comment 25

[[e-mail]]

Comment on attachment 131460 [details] [diff] [review]
Patch with Neil's comments

Note that the first hunk appears to conflict with your cleanup patch.

Comment 26

[Alec Flett]

Comment on attachment 131460 [details] [diff] [review]
Patch with Neil's comments

sorry for the delay...looks good.. sr=alecf

Comment 27

[R.J. Keller]

Fix checked in.

Comment 28

[Daniel Wang]

v