Closed
Bug 136901
Opened 23 years ago
Closed 22 years ago
toOpenWindowByType should never open multiple windows
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: polish)
Attachments
(1 file, 1 obsolete file)
|
4.27 KB,
patch
|
janv
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Currently bookmarks and history have to work around this.
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
|
|
Assignee | |
Comment 3•23 years ago
|
||
*** Bug 158624 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Comment 4•23 years ago
|
||
Bad luck Blake, I'm going on holiday until August so someone else will have to
do it instead.
|
|
Assignee | |
Updated•23 years ago
|
Attachment #78728 -
Flags: superreview?(bzbarsky)
Attachment #78728 -
Flags: review?(blaker)
|
||
Comment 5•22 years ago
|
||
Comment on attachment 78728 [details] [diff] [review]
Proposed Patch
Um... Why is this using openDialog() exactly? And what's up with the
indentation where toNewWindow() is called?
Attachment #78728 -
Flags: superreview?(bzbarsky) → superreview-
|
|
Assignee | |
Comment 6•22 years ago
|
||
I had to incorporate the toNewWindow code because toOpenWindow only works on
loaded windows.
Attachment #78728 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Attachment #127239 -
Flags: superreview?(bzbarsky)
Attachment #127239 -
Flags: review?(varga)
|
|
||
Updated•22 years ago
|
Attachment #127239 -
Flags: superreview?(bzbarsky) → superreview+
|
||
Comment 7•22 years ago
|
||
Comment on attachment 127239 [details] [diff] [review]
Updated for bitrot
this looks good
Attachment #127239 -
Flags: review?(varga) → review+
|
|
Assignee | |
Comment 8•22 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Comment 9•22 years ago
|
||
Comment on attachment 78728 [details] [diff] [review]
Proposed Patch
clearing review request for obsolete patch
Attachment #78728 -
Flags: review?(blakeross)
|
||
Updated•21 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•