136956 - HTTP preferences panel needs to control proxy settings as well

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[Darin Fisher]

HTTP preferences panel needs to control proxy settings as well.

if you enable pipelining under the "HTTP Networking" preferences panel, it only
enables pipelining for normal/direct connections.  it should also enable
pipelining for proxy connections.  or perhaps we need another checkbox.

the same is true of the persistent connections checkbox.

here's the full set of prefs:

network.http.version
[network.http.proxy.version <- does not exist yet]
network.http.keep-alive
network.http.proxy.keep-alive
network.http.pipelining
network.http.proxy.pipelining

Comment 1

[Darin Fisher]

marking this bug nsbeta1 since the existing preferences dialog doesn't work for
proxy users.

Comment 2

[Kathleen :Brade]

Attachment: screenshot without any string changes (proxy is on right side ;-))

Comment 3

[Kathleen :Brade]

Attachment: preliminary patch without string changes

note that this patch doesn't fix network.http.version ->
network.http.proxy.version since that pref isn't defined yet (and prefs code
doesn't like it when it isn't defined apparently).

comments? feedback?

Comment 4

[Ryan Cassin]

brade: Is my build out of date or is yours (???) -- in the list on the left of 
the preferences window it's not the "HTTP" pane, it's the "HTTP Networking" 
pane .. I'm confused.

Comment 5

[Kathleen :Brade]

interesting... I took the screenshot on my Mac (which gave me a native PICT
file).  That shows:  HTTP Network...
However, I converted the PICT to a jpeg and it got truncated to just "HTTP";
very bizarre!

Comment 6

[Kathleen :Brade]

Comment on attachment 78787 [details]
screenshot without any string changes (proxy is on right side ;-))

doh! I uploaded the wrong file (I have two files named "screenshot.jpeg")

SORRY!

Comment 7

[Kathleen :Brade]

Attachment: screenshot (hopefully the correct file this time)

Comment 8

[Kathleen :Brade]

Attachment: better patch without string changes

Here is a better patch without use of max-width (much improved; thanks to
timeless for the suggestions).

Comment 9

[Darin Fisher]

here's where "Enable Keep-Alive" would be better than "Enable Persistent
Connections" since we're short on space :-)

also, we need to come up with text for the headings, and i need to implement
network.http.proxy.version!  see bug 60811.

the right hand side panel (the proxy one i presume) should perhaps be disabled
if "Direct Connection to the Internet" is selected in the proxy panel.  although
this is probably not a requirement.

Comment 10

[Kathleen :Brade]

Attachment: updated patch to cleanup variable names and id strings

reviews please?

Darin--we should file another bug on the update issue or hold off on that; I'd
like to land the minimal stuff on the trunk to get some exposure

Comment 11

[Darin Fisher]

Attachment: brade's patch + network.http.proxy.version + changes to the wording

feel free to suggest alternative wording... i'll attach a screenshot next.

Comment 12

[Darin Fisher]

Attachment: screenshot w/ my patch

Comment 13

[Kathleen :Brade]

Comment on attachment 79661 [details] [diff] [review]
brade's patch + network.http.proxy.version + changes to the wording

This is great except for the problem with accesskeys.  Those are duplicated but
shouldn't be.

Darin--would you like me to modify this patch to fix that issue or do you want
to?

Comment 14

[Darin Fisher]

Attachment: minor revision to fix accesskeys

Comment 15

[Darin Fisher]

Comment on attachment 79716 [details] [diff] [review]
minor revision to fix accesskeys

got an r=brade via AIM.

Comment 16

[Darin Fisher]

-> me for checkin

Comment 17

[Darin Fisher]

mcarlson, marlon: i'd really like some UE approval on this patch.  please see
attachment 79664 [details].  thx!

Comment 18

[Kathleen :Brade]

Darin--I forgot to tell you to remove "prefNetworking.label" from dtd file since
you aren't using it anymore.  :-)
 

Comment 19

[Darin Fisher]

brade: sure thing!

Comment 20

[Darin Fisher]

Attachment: revised patch - removed unused prefNetworking.label from .dtd file

Comment 21

[Darin Fisher]

Comment on attachment 79892 [details] [diff] [review]
revised patch - removed unused prefNetworking.label from .dtd file

carrying forward r=brade

Comment 22

[Alec Flett]

Comment on attachment 79892 [details] [diff] [review]
revised patch - removed unused prefNetworking.label from .dtd file

easy 'nough. 
so access keys aren't case-sensitive? (I see a lower case "i" and a lower-case
"s" - just making sure
sr=alecf with that assumption

Comment 23

[Darin Fisher]

yeah, they aren't case sensitive... i was just playing around with something. 
i'll make them all uniform before checking in.  thx!

Comment 24

[Darin Fisher]

fixed-on-trunk

Comment 25

[Michele Carlson]

You have l10n approval for UI changes that are post - beta. In other words, if
this is not landing on the branch until after beta ships, then the changes are
fine. thanks

Comment 26

[timeless]

darin: while accesskeys aren't case sensitive, the algorithms in at least some 
places favor the case you pick.

Comment 27

[[e-mail]]

...so don't blindly change all the access keys to lower case (upper is OK, though)

Comment 28

[chris hofmann]

Comment on attachment 79892 [details] [diff] [review]
revised patch - removed unused prefNetworking.label from .dtd file

a=chofmann for 1.0.1

Comment 29

[Darin Fisher]

fixed-on-branch (got ADT approval for these UI changes)

Comment 30

[Tom Everingham]

taking this sairuh since I just used those preferences to test another bug

verified trunk - 06/04/02 builds - winNT4, linux rh6, mac osX

Comment 31

[Tom Everingham]

verified branch - 06/04/02 builds - winNT4, linux rh6, mac osX