137254 - "Web Search for" should be "Search Web for"

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Jesse Ruderman]

Most of the items on our context menu items start with verbs, so I think "web
search" on the selection context menu should be changed to "search web".

Now:
 Web Search for "selected"
 Dictionary (or Dictionary Lookup)

My suggestion:
 Search Web for "selected"
 Search Dictionary (or Look Up in Dictionary)

Comment 1

[Diego Biurrun]

Jesse, please provide some steps to reproduce, I have "Search Netscape
Search..." on my context menu when I highlight some string on a page.

Comment 2

[Bernard Alleysson]

just select some text in this page then right click

1- for instance, <--- select "instance"
2 - right click

results:

last menu option is "Web Search for "instance""

Comment 3

[Diego Biurrun]

Attachment: updates the search context menu wording

Comment 4

[Diego Biurrun]

Now I understand, seems like my build was not up-to-date enough.

Yes, the wording is horrible.  I attached a small patch that fixes the problem.
 It also changes the accesskey from W to S, this should be safe, S does not
appear to be used in the context sensitive context menu.

blaker, marlon, mpt please review and give r=/sr= or suggestions.

Comment 5

[Sebastian Biallas]

Diego Biurrun: Dont change the accesskey from 'W' to 'S': Highlight some text,
click on an image.. 'S' is used for '_S_et As Wallpaper'.
(but IMO you could swap those to accesskeys; this sounds much more logical)

Comment 6

[Jesse Ruderman]

"Set as Wallpaper" won't confict with "Search Web for ..." once bug 135225 is
fixed.  Bug 135225 is "don't mix selection and non-selection context menus
(accesskey dups)".

Comment 7

[Diego Biurrun]

I added the dtd where the accesskeys are defined to the URL field.  See for
yourself, "S" is defined in various places.  I changed from "W" to "S" since
this is not used in the respective context menu on Linux, but there is no "Set
as Wallpaper" in my Linux context menu, so maybe I missed it because of that. 
But as Jesse said, this should not be a problem.

Comment 8

[timeless]

uid is being phased out.

Comment 9

[Prognathous]

Diego Biurrun, could please check that your patch is still valid and ask for
reviews? you haven't set any review flags last time.

Thanks,

Prog.

Comment 10

[Diego Biurrun]

Attachment: wording update - minus the bitrot

Thanks for reminding me of this, it had definitely slipped through the cracks. 
Patch remade, it had bitrotted.  Sorry, I have no access to a CVS tree right
now, I hope it applies cleanly nevertheless.

Comment 11

[Diego Biurrun]

Comment on attachment 140828 [details] [diff] [review]
wording update - minus the bitrot

Blake, could you either r= or sr= this and suggest someone for the other
review?  This patch is very trivial.  I think it is a candidate for rs=.

Comment 12

[Blake Ross]

Fix checked in. Thanks for the patch!

Comment 13

[Jesse Ruderman]

This bug was filed against Seamonkey but I think Blake only fixed it in Firefox.

Comment 14

[Stefan Borggraefe]

Reopening. This was indeed only checked in for Firefox.

Comment 15

[Tim Meader]

Attachment: Patch for the rest of Mozilla, plus help files (including one for Firefox)

I've gone ahead and changed all the necessary spots for Mozilla Suite to mirror
the changes that have already been checked into Firefox. The previous patch
didn't change the text for the help files, I've done that too.

Comment 16

[Tim Meader]

Comment on attachment 149013 [details] [diff] [review]
Patch for the rest of Mozilla, plus help files (including one for Firefox)

Going ahead and setting for review. Blake, hoepfully, being a Firefox driver,
you can also go ahead and merge in the one change that's included for the
firefox side.

Comment 17

[jag (Peter Annema)]

Comment on attachment 149013 [details] [diff] [review]
Patch for the rest of Mozilla, plus help files (including one for Firefox)

r=jag

Comment 18

[Tim Meader]

Comment on attachment 149013 [details] [diff] [review]
Patch for the rest of Mozilla, plus help files (including one for Firefox)

Submitting for review to mconner to hopefully get this into Firefox so
everything is squared away.

Comment 19

[Tim Meader]

Apologies, this has already been reviewed and approved by jag, but I didn't see
how to request a second review without removing the first for this patch. My
request from mconner is merely to get someone on the Firefox side specifically
to approve this patch for that product. Very minor.

Comment 20

[Mike Connor [:mconnor]]

Comment on attachment 149013 [details] [diff] [review]
Patch for the rest of Mozilla, plus help files (including one for Firefox)

r=[e-mail] for the Fx parts

Comment 21

[Boris Zbarsky [:bzbarsky]]

Checked that last patch into the trunk (both for SeaMonkey and Firefox).  I
don't know what the procedure is for landing the help changes on aviary branch;
Mike, can you deal with that?

Comment 22

[Mike Connor [:mconnor]]

yeah, will be doing a round of checkins later today

Comment 23

[Mike Connor [:mconnor]]

today being loosely defined, of course, done now.