Closed
Bug 140183
Opened 22 years ago
Closed 22 years ago
[RTM]Add an attribute to PrintSettings that allows us silent printing
Categories
(Core :: Printing: Output, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: racham, Assigned: rods)
References
Details
(Whiteboard: [adt1 rtm],custrtm-)
Attachments
(1 file, 1 obsolete file)
3.78 KB,
patch
|
danm.moz
:
review+
sspitzer
:
superreview+
chofmann
:
approval+
|
Details | Diff | Splinter Review |
Adding summary from one of the emails exchanged between Rodney, Dan & myself. The problem is the Progress dialog is intended to be non-modal, but it becomes modal when parented to a model dialog. Once the dialog is modal, that's it, nothing can really print. A different solution may be to add it to the PrintSettings, we now have a call for indicating "silent" as in don't disable the Print Dialog, well maybe we add a attr that says we shouldn't display the Progress either. (I like this one low impact easy to implement, low risk) Without this attribute, we can't really print when the window that triggers print progress dialog is a modal window. ISPs can also be blocked from having any terms and conditions they may want user to print from the customized wizard pages. Rod has already provided a patch for this. Will post that in the next update.
Added keywords. Samir & Dan for input & reviews.
Keywords: nsbeta1
Attachment #81073 -
Attachment is obsolete: true
Attachment #81223 -
Flags: review+
Comment 4•22 years ago
|
||
Comment on attachment 81223 [details] [diff] [review] same patch with diff options -uw r=sgehani
Comment 6•22 years ago
|
||
Comment on attachment 81223 [details] [diff] [review] same patch with diff options -uw sr=sspitzer
Attachment #81223 -
Flags: superreview+
Fix checked in on trunk. Adding adt1.0.0 keyword.
Status: NEW → ASSIGNED
Keywords: adt1.0.0
Assignee | ||
Updated•22 years ago
|
Target Milestone: --- → mozilla1.0
Comment 8•22 years ago
|
||
We can ship Beta without this. But this is required for rtm so adding appropriate keywords.
Assignee | ||
Updated•22 years ago
|
Summary: Add an attribute to PrintSettings that allows us silent printing → [RTM]Add an attribute to PrintSettings that allows us silent printing
Comment 9•22 years ago
|
||
Resolving as fixed since it has been fixed on the trunk. Please add fixed1.0.0 keyword when the patch has been checked into the branch.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 10•22 years ago
|
||
Racham, please verify when you get chance...thanks!
Reporter | ||
Comment 11•22 years ago
|
||
code verified. This one still need to make it's way onto the branch. So, will add correponding keywords then.
Status: RESOLVED → VERIFIED
Comment 12•22 years ago
|
||
Adding adt1.0.0+ -- please get drivers approval and land in the branch.
Comment 13•22 years ago
|
||
Comment on attachment 81223 [details] [diff] [review] same patch with diff options -uw a=chofmann,dbaron,valeski for the 1.0 branch
Attachment #81223 -
Flags: approval+
Assignee | ||
Updated•22 years ago
|
Keywords: fixed1.0.0
Comment 14•22 years ago
|
||
Racham, if you can verify this on branch also and add "verified1.0.0" keyword...thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•