140474 - PK11_FindCertsFromNickname may cause an assertion failure in nssList_GetArray.

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

nssList_GetArray asserts that the maxElements argument is > 0.
nssList_GetArray will malfunction if maxElements is 0.

It is possible for PK11_FindCertsFromNickname to call nssList_GetArray
with maxElements equal to 0, which causes the assertion to fail:
        if (nameList) {
            count = nssList_Count(nameList);
            foundCerts = nss_ZNEWARRAY(NULL, NSSCertificate *, count + 1);
            nssList_GetArray(nameList, (void **)foundCerts, count);
            nssList_Destroy(nameList);
        }

Comment 1

[Ian McGreer]

Attachment: patch against 3.4 branch

Comment 2

[Ian McGreer]

patch checked in to branch, closing bug.

This fix is not needed for the tip.

Comment 3

[Wan-Teh Chang]

Comment on attachment 81485 [details] [diff] [review]
patch against 3.4 branch

I think strictly speaking we also need to handle the
failure of nss_ZNEWARRAY (out-of-memory error), that
is, something like:

	foundCerts = nss_ZNEWARRAY(NULL, NSSCertificate *, count + 1);
	if (foundCerts) {
	    nssList_GetArray(nameList, (void **)foundCerts, count);
	}

but this patch is a strict improvement over the old code.

r=wtc.

Comment 4

[Wan-Teh Chang]

Set target milestone to NSS 3.4.2.

Comment 5

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch. Pls check this in
asap. thanks!