140649 - Mail and newsgroup "set as default" should be disabled on current default

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Nathaniel]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
Gecko/20020426
BuildID:    2002042603

In the "Mail & Newsgroups Account Settings", the "set as default" button is
enabled for every user account, but should be disabled for the one that is
already default (if only to provide reinforcement that the default is in fact
correctly set).

Reproducible: Always
Steps to Reproduce:
Edit > Mail and newsgroups account settings
highlight any mail account

Actual Results:  "set as default" always active

Expected Results:  "set as default" should be inactive for existing default

Comment 1

[Henrik Gemal]

does the button do anything? I think it should be removed since it doesn't seem
to do anything.

Comment 2

[Jason M. Abels]

I agree. The button does do anything, but there is visual confirmation about
which account is set as default (other than exiting prefs and seeing which
account is listed first.

Comment 3

[Stefan Borggraefe]

> does the button do anything?

On Windows XP you see the New Message count from the Default Account on the
Change User screen. So this setting is actually used.

Comment 4

[Stefan Borggraefe]

Taking bug since I have a fix for it.

Comment 5

[Stefan Borggraefe]

Attachment: Fix

This fix also disables the button when canSetDefault from the incoming Server
of an account is false.

Comment 6

[[e-mail]]

Comment on attachment 135395 [details] [diff] [review]
Fix

>+    if (isAlreadyDefaultAccount ||
Just use currentDefaultAccount == accountManager.defaultAccount
>+        !server.canBeDefaultServer ||
Neat.

Comment 7

[Stefan Borggraefe]

Attachment: Addressed Neil's comment.

> Just use currentDefaultAccount == accountManager.defaultAccount

This wouldn't work, but I think you just wanted me to eliminate the boolean
variable isAlreadyDefaultAccount, right? ;-)

Comment 8

[[e-mail]]

Comment on attachment 135397 [details] [diff] [review]
Addressed Neil's comment.

Actually I think I meant account == accountManager.defaultAccount

Comment 9

[Stefan Borggraefe]

Attachment: Final patch

> Actually I think I meant account == accountManager.defaultAccount

Ah, ok, made it like you said.

Comment 10

[[e-mail]]

Comment on attachment 135399 [details] [diff] [review]
Final patch

See how simple that was?

Comment 11

[Stefan Borggraefe]

Checked in by timeless. Thanks for this and the super-fast reviews. :-)

Comment 12

[Scott MacGregor]

I can no longer set any account as default using an 11/14 build. Every account
always has this button disabled for me. 

Comment 13

[Mike Cowperthwaite]

I cannot replicate that symptom; I am seeing the Default button enabled for 
three of my four mail accounts (all POP), and disabled for News and Local 
Folders.

Comment 14

[Stefan Borggraefe]

Scott: I tested this with TB on Linux and Seamonkey on Linux and Windows. I can
select a default account in all cases.

To clarify, the button is disabled when:
- the account is already the default account.
- the account can't be a default account (NNTP, Movemail and Local Folder)
- the account has less than one identity (This is currently only the case for
Local Folder as far as I can see)

So you need at least two account of the type POP3 or IMAP to be able to change
the Default Account.

Comment 15

[Scott MacGregor]

that was my problem then Stefan. I was trying to select a news acct. I did not
have a 2nd pop/imap acct. Thanks for the clarification.