Closed
Bug 141247
Opened 22 years ago
Closed 19 years ago
Enable HTML dir listings
Categories
(Core :: Networking: File, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: chak, Assigned: darin.moz)
References
Details
(Keywords: topembed-)
Attachments
(1 file)
7.31 KB,
patch
|
dougt
:
review+
darin.moz
:
superreview+
jesup
:
approval+
|
Details | Diff | Splinter Review |
We need to enable html dir listsings for file:// url's. This is needed for a key embedding customer
Reporter | ||
Comment 1•22 years ago
|
||
Adding kwd : topembed+ Adding dependency on : 141235
Reporter | ||
Comment 2•22 years ago
|
||
Comment 3•22 years ago
|
||
Comment on attachment 81711 [details] [diff] [review] Patch to enable html dir listings based on a pref r=dougt. Worse is better. this has some know intl problems, but we can work them out later.
Attachment #81711 -
Flags: review+
Assignee | ||
Comment 4•22 years ago
|
||
Comment on attachment 81711 [details] [diff] [review] Patch to enable html dir listings based on a pref >Index: src/nsFileChannel.cpp >+ if (mGenerateHTMLDirs) >+ { >+ PRBool directory; >+ mFile->IsDirectory(&directory); // this stat should be cached and will not hit disk. >+ if (directory) { >+ rv = SetStreamConverter(); >+ if (NS_FAILED(rv)) >+ return rv; >+ } >+ } some indentation badness. with that fix, sr=darin
Attachment #81711 -
Flags: superreview+
Reporter | ||
Comment 5•22 years ago
|
||
Fixed indentation issues per Darin's comments above and landed the patch on the trunk.
Reporter | ||
Comment 6•22 years ago
|
||
Marking FIXED since the patch got checked into the trunk Adding adt1.0.0 to get ADT's attention for 1.0 branch checkin
Adding dep to 121324: there is a pref change here: + if (NS_SUCCEEDED(rv) || pPref) { + pPref->GetBoolPref("network.dir.generate_html", &mGenerateHTMLContent); + } +
Blocks: 121324
Comment 8•22 years ago
|
||
Adding adt1.0.0+. After getting drivers approval, please check this into the branch as soon as possible and add the fixed1.0.0 keyword.
Comment 9•22 years ago
|
||
Comment on attachment 81711 [details] [diff] [review] Patch to enable html dir listings based on a pref a=rjesup@wgate.com (and asa) for drivers for branch checkin. Make sure it's in trunk too.
Attachment #81711 -
Flags: approval+
Comment 11•22 years ago
|
||
how could we test this bug? can someone put down reproduce procedure? do we need to test with the pref turn on and turn off?
Comment 12•22 years ago
|
||
which protocol will be the impact ? file:/// protocol ? ftp:// protocol ? any other protocols?
Reporter | ||
Comment 13•22 years ago
|
||
This change is just for the file:// protocol handler. ftp:// already does dir listings in html format.
Comment 14•22 years ago
|
||
do we need to add some pref to verify the real fix ?
Comment 15•22 years ago
|
||
network.dir.generate_html
Comment 16•22 years ago
|
||
It looks like both the xul and html version of file: and ftp:// listing is broken for non ascii without this patch so this patch won't introudce any intl regression. We need to fix both issue thought. but that is out of the scope of this bug.
Comment 17•21 years ago
|
||
-> file qa to me. (I don't know why this is browser-general)... LXR shows this is only in the 1.0 branch: http://lxr.mozilla.org/mozilla1.0/search?string=network.dir.generate_html http://lxr.mozilla.org/mozilla/search?string=network.dir.generate_html The problem is that it doesn't work on the 1.0 branch: Netscape 7.02 (Mozilla 1.0.2 based) I turn on the pref and set it to true. I still get file directories w/ XUL. Chimera: This pref is in the ./default/prefs/all-chimera.js file, but flipping the value to false does not get me file: dirs in XUL trees. Mozilla 1.4a: Setting this pref by hand, and turning it to false, I still get HTML directories. REOPEN: If this is a 1.0 fix, it doesn't work. If this is a trunk bug, it can't be marked fixed, b/c it was never checked in.
Status: RESOLVED → REOPENED
Component: Browser-General → Networking: File
QA Contact: imajes-qa → benc
Resolution: FIXED → ---
Comment 18•21 years ago
|
||
-fixed1.0.0. I think this means his shows up in the topembed+ query. Sorry, I don't think we had a clear proceedure for reopening these types of bugs, so this is the natural state if I do the individual changes correctly.
Keywords: fixed1.0.0
Comment 20•21 years ago
|
||
Can someone tell me what the current expected behavior is? As I understand it, file: URL directory listings are HTML-only, w/ no possibility of using XUL.
Comment 21•21 years ago
|
||
while pruning my old bugmail from a work bug tracker, I found a comment that said that this was checked in and fixed for 1.0. My impression is that what really happened was that the code tree was hacked to do HTML only, and that this pref is dead. I've looked in LXR on the trunk, and found only the pref in the chimera all.js.
Comment 22•20 years ago
|
||
-> defaults. Is this solved by fixing bug 238257?
Assignee: chak → darin
Status: REOPENED → NEW
Comment 23•19 years ago
|
||
RESOLVED/FIXED: Original patch seems to have set the default for file: to HTML, but also implemented a pref that was not working (newtork.dir.generate_html). This pref was changed in the fix for bug 102812, which took effect about 1.3a. That explains my confusion in #17 and other places. Bug 238257 fixed the problem where the pref selection was not working.
Status: NEW → RESOLVED
Closed: 22 years ago → 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•