141247 - Enable HTML dir listings

Status: RESOLVED FIXED

(Core :: Networking: File, defect)

Description

[Chak Nanga]

We need to enable html dir listsings for file:// url's. This is needed for a key
embedding customer

Comment 1

[Chak Nanga]

Adding kwd : topembed+

Adding dependency on : 141235

Comment 2

[Chak Nanga]

Attachment: Patch to enable html dir listings based on a pref

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 81711 [details] [diff] [review]
Patch to enable html dir listings based on a pref

r=dougt.  Worse is better.  this has some know intl problems, but we can work
them out later.

Comment 4

[Darin Fisher]

Comment on attachment 81711 [details] [diff] [review]
Patch to enable html dir listings based on a pref

>Index: src/nsFileChannel.cpp
>+        if (mGenerateHTMLDirs)
>+        {
>+            PRBool directory;
>+		    mFile->IsDirectory(&directory);  // this stat should be cached and will not hit disk.
>+		    if (directory) {
>+                rv = SetStreamConverter();
>+                if (NS_FAILED(rv)) 
>+                    return rv;
>+            }
>+        }

some indentation badness.

with that fix, sr=darin

Comment 5

[Chak Nanga]

Fixed indentation issues per Darin's comments above and landed the patch on the
trunk.

Comment 6

[Chak Nanga]

Marking FIXED since the patch got checked into the trunk

Adding adt1.0.0 to get ADT's attention for 1.0 branch checkin

Comment 7

[tao]

Adding dep to 121324: there is a pref change here:

+    if (NS_SUCCEEDED(rv) || pPref) { 
+        pPref->GetBoolPref("network.dir.generate_html", &mGenerateHTMLContent);
+    }
+

Comment 8

[scottputterman]

Adding adt1.0.0+.  After getting drivers approval, please check this into the
branch as soon as possible and add the fixed1.0.0 keyword.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 81711 [details] [diff] [review]
Patch to enable html dir listings based on a pref

a=[e-mail] (and asa) for drivers for branch checkin.  Make sure it's in
trunk too.

Comment 10

[Chak Nanga]

Fixed checked into the Mozilla 1.0 branch

Comment 11

[Frank Tang]

how could we test this bug? can someone put down reproduce procedure?
do we need to test with the pref turn on and turn off?

Comment 12

[Frank Tang]

which protocol will be the impact ? file:/// protocol ? ftp:// protocol ? any
other protocols?

Comment 13

[Chak Nanga]

This change is just for the file:// protocol handler. ftp:// already does dir
listings in html format.

Comment 14

[Frank Tang]

do we need to add some pref to verify the real fix ?

Comment 15

[Doug Turner (:dougt)]

network.dir.generate_html

Comment 16

[Frank Tang]

It looks like both the xul and html version of file: and ftp:// listing is
broken for non ascii without this patch so this patch won't introudce any intl
regression. We need to fix both issue thought. but that is out of the scope of
this bug. 

Comment 17

[benc]

-> file
qa to me. (I don't know why this is browser-general)...

LXR shows this is only in the 1.0 branch:
http://lxr.mozilla.org/mozilla1.0/search?string=network.dir.generate_html
http://lxr.mozilla.org/mozilla/search?string=network.dir.generate_html

The problem is that it doesn't work on the 1.0 branch:
Netscape 7.02 (Mozilla 1.0.2 based) I turn on the pref and set it to true. 
I still get file directories w/ XUL.

Chimera:
This pref is in the ./default/prefs/all-chimera.js file, but flipping the value
to false does not get me file: dirs in XUL trees.

Mozilla 1.4a:
Setting this pref by hand, and turning it to false, I still get HTML directories.

REOPEN:
If this is a 1.0 fix, it doesn't work.
If this is a trunk bug, it can't be marked fixed, b/c it was never checked in.

Comment 18

[benc]

-fixed1.0.0.

I think this means his shows up in the topembed+ query. Sorry, I don't think we
had a clear proceedure for reopening these types of bugs, so this is the natural
state if I do the individual changes correctly.

Comment 19

[saari (gone)]

topembed-

Comment 20

[benc]

Can someone tell me what the current expected behavior is?

As I understand it, file: URL directory listings are HTML-only, w/ no
possibility of using XUL.

Comment 21

[benc]

while pruning my old bugmail from a work bug tracker, I found a comment that
said that this was checked in and fixed for 1.0.

My impression is that what really happened was that the code tree was hacked to
do HTML only, and that this pref is dead.

I've looked in LXR on the trunk, and found only the pref in the chimera all.js.

Comment 22

[benc]

-> defaults. Is this solved by fixing bug 238257?

Comment 23

[benc]

RESOLVED/FIXED:

Original patch seems to have set the default for file: to HTML, but also
implemented a pref that was not working (newtork.dir.generate_html).

This pref was changed in the fix for bug 102812, which took effect about 1.3a.

That explains my confusion in #17 and other places.

Bug 238257 fixed the problem where the pref selection was not working.