1414212 - Enable titlebar rendering on Gtk+ >= 3.10

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Investigate possibility to enable titlebar rendering on old Gtk+ version as GtkHeaderBar was introduced at Gtk+ 3.10. That brings better UI experience to Enterprise/LTS distros.

Comment 1

[N. W.]

Can you please enable this for Nightly now? Most Ubuntu users and most Ubuntu based distros are based on Ubuntu 16.04 Xenial Xerus, which unfortunately ships with GTK+ 3.18 only.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Sure, I'll look at it.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1414212 - Enable titlebar rendering on Gtk+ >= 3.10,

Review commit: https://reviewboard.mozilla.org/r/200324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200324/

Comment 4

[Jan Horak [:jhorak]]

Comment on attachment 8929003 [details]
Bug 1414212 - Enable titlebar rendering on Gtk+ >= 3.10,

https://reviewboard.mozilla.org/r/200324/#review205420

Comment 5

[N. W.]

The new Nightly build in https://launchpad.net/~ubuntu-mozilla-daily/+archive/ubuntu/ppa now has the "widget.allow-client-side-decoration" pref available in about:config.

Setting it to "true" does not do anything on Ubuntu 16.04 though. 16.04 uses GTK+ 3.18: https://packages.ubuntu.com/search?suite=all&section=all&arch=any&keywords=libgtk-3&searchon=names

So, it would be nice if you could also enable it for GTK+ >= 3.10 so that Ubuntu 16.04 users can also use CSD.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54128381bfe5
Enable titlebar rendering on Gtk+ >= 3.10, r=jhorak

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/54128381bfe5

Comment 8

[Terrell Kelley]

Is this in the current Nightly as downloaded from the official Mozilla site? I didn't see widget.allow-client-side-decoration in about:config, and creating the key and setting it didn't seem to do anything, even upon restart.

I'm stuck on ESR until I get this fixed, since it can still use the Hide Caption Title Bar Plus extension

Comment 9

[Marco Castelluccio [:marco]]

(In reply to Terrell Kelley from comment #8)
> Is this in the current Nightly as downloaded from the official Mozilla site?
> I didn't see widget.allow-client-side-decoration in about:config, and
> creating the key and setting it didn't seem to do anything, even upon
> restart.

The pref was removed, now you can enable it from customize mode (bottom right of the page) or by setting "browser.tabs.drawInTitlebar" to true.
If it still doesn't work, what is your DE? Can you paste $XDG_CURRENT_DESKTOP?

Comment 10

[Terrell Kelley]

Ah. I didn't even notice. Yes, that does turn the title bar off. 

I do notice a lack of the min, max, and close buttons, though. Is that intentional? I personally like the extra space*, as I never use the window except maximized, but I thought I'd mention it. 

I presume the DE is the same thing as the window manager. I use JWM (Joe's Window Manager), the default that comes with Puppy Linux. It is extremely lean and adds no dependencies other than Xlib.

Comment 11

[Terrell Kelley]

Oh, and dragging the tab bar doesn't do anything, either.

Comment 12

[Marco Castelluccio [:marco]]

(In reply to Terrell Kelley from comment #10)
> Ah. I didn't even notice. Yes, that does turn the title bar off. 
> 
> I do notice a lack of the min, max, and close buttons, though. Is that
> intentional? I personally like the extra space*, as I never use the window
> except maximized, but I thought I'd mention it. 
> 
> I presume the DE is the same thing as the window manager. I use JWM (Joe's
> Window Manager), the default that comes with Puppy Linux. It is extremely
> lean and adds no dependencies other than Xlib.

No, it isn't expected. Please file a new bug blocking bug 1283299.

Comment 13

[Terrell Kelley]

Okay. I believe I've figured out how to do that: bug 1424158