142459 - Shift+click on scroll bar should jump to that location

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Win32, enhancement)

Description

[Lewis Jardine]

Windows scrollbar widgets, when shift is held down, will jump to wherever they
are clicked, as if the mouse had gone to where the grippy was, and dragged it to
its current location. Under windows, mozilla scrollbars should do the same.

Reproducable: always

steps to reproduce:

1 - open an explorer window, and a mozilla window. Point explorer at c:\,
details mode. Open www.theregister.co.uk (or any other page longer than one
screen) in mozilla.

2 - shift-click near the bottom of each scrollbar (but not on the grippy).
Explorer's grippy teleports to the mouse location; mozilla's moves down a page.

3 - If the grippy is large enough, shift-click off of the center of the grippy.
Explorer's grippy centers itself on the pointer; mozilla's does stays still.

Comment 1

[Warner Young]

Maybe Windows 2000 only?  I can't get this to happen with Windows Explorer in Win98.

Comment 2

[John Morrison]

It's a win2k thang. There is a duplicate of this (or at least an RFE for 
implementing some of the win2k scrolling inn-o-va-tion).

Comment 3

[Jesse Ruderman]

I have Windows 98.  IE 6 has this feature, and it works even if you click in the
scrollbar thumb (as described by the reporter).  Shift+clicking anywhere in the
elevator pulls the scrollbar thumb so that the center of the thumb is where you
clicked.  Neat feature, I didn't know about it.

Didn't find any dups on the searches:
enh scroll
ALL shift,shft scroll
ALL 2000,2k scroll

jrgm, since you've seen the other bug, do you know how to find it?

Comment 4

[timeless]

i know i filed a bug about context menus for scrollbars (esp: scroll here). it 
never occured to me that there was a menuless way to get that. wow. (tested 
cmd.exe, nc4.78w32)

Comment 5

[Jesse Ruderman]

See also bug 162620 for Mac (Option-click) and bug 24117 for Linux
(Middle-click, fixed in 2000).

Comment 6

[Oleg Sidletskiy]

*** Bug 193592 has been marked as a duplicate of this bug. ***

Comment 7

[timeless]

.

Comment 8

[[e-mail]]

Attachment: Proposed patch

The first two hunks bring shift+click into line with middle click.
The third hunk prevents autorepeat scrolling for shift clicks.

Comment 9

[Jan Varga [:janv]]

Comment on attachment 134491 [details] [diff] [review]
Proposed patch

nice notation
r=varga

Comment 10

[[e-mail]]

Comment on attachment 134491 [details] [diff] [review]
Proposed patch

In case you're still accepting enhancements; this patch is low risk because it
reuses all the code that does the hard work. Tested on RH7.3 and MingW builds.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 134491 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to 1.6beta

Comment 12

[[e-mail]]

Fix checked in.