143154 - Password manager is OFF but the option to save password is still ON in publishing setup in Composer

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[TucsonTester1]

If password manager is OFF the Save Password option in Publish Page > settings 
should not be active or should give a prompt to turn password manager ON.  
Navigator does not prompt to save password if password manager is OFF, so not 
sure why it is an option for publishing when it is OFF.  Help > Using privacy 
features > Using the Password manager > Turning on and off > "Password Manager 
is on by default." it is off when I installed on WIN2000.

Comment 1

[Stephen P. Morse]

Reassigning

Comment 2

[sujay]

--> cmanske

Comment 3

[Charles Manske]

Steve: Is there a pref I can check to tell if Password manager is turned off?

Comment 4

[Stephen P. Morse]

Yes, it's signon.rememberSignons

Comment 5

[Charles Manske]

Attachment: patch v1

Use password mananager prefs to set disable state of "Save Password" checkbox
and don't save if it is turned off.

Comment 6

[Kathleen :Brade]

Comment on attachment 95260 [details] [diff] [review]
patch v1

I don't understand why gPasswordManagerOn needs to be global; can't you just
make that a function and call it the one or two places that you need it?

I would prefer to see this made into a utility function (or something similar):
+  var prefs = GetPrefs();
+  if (prefs)
+  {
+    try {
+      gPasswordManagerOn = prefs.getBoolPref("signon.rememberSignons");
+      gDialog.SavePassword.disabled = !gPasswordManagerOn;
+    } catch (e) {}
+  }

Comment 7

[Charles Manske]

Attachment: patch v2

Added a couple of "get prefs" utilities as requested by reviewer

Comment 8

[Kathleen :Brade]

Comment on attachment 95438 [details] [diff] [review]
patch v2

r=brade
but I don't see much point in having a local var "prefs" inside the various
pref calls; this should be equivalent:
 function GetBoolPref(name)
 {
   if (name) // is this needed?
   {
     try {
       return GetPrefs().getBoolPref(name);
     } catch (e) {}
   }
   return "";
 }

Comment 9

[Joe Hewitt (gone)]

Comment on attachment 95438 [details] [diff] [review]
patch v2

sr=hewitt

Comment 10

[Charles Manske]

checked into 1.2 trunk

Comment 11

[sairuh (rarely reading bugmail)]

"save password" checkbox is disabled when passwd mgr is disabled.

vrfy'd fixed with 2003.02.19 comm trunk on win2k and linux rh8.0.