Closed Bug 14342 Opened 25 years ago Closed 24 years ago

Composer menu work - tracking bug for all menu items.

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: sujay, Assigned: cmanske)

References

Details

(Whiteboard: [nsbeta2+ until 5/16] Composer feature work) 

using 9/20 build of apprunner on all platforms:

the following UI menu items need to be implemented and added
to the editor based on comparison to 4.x:

align
list
preferences
decrease/increase indent
table menu itself
context sensitive obj props
new page from wizard, template
HTML source
browse page
send page
publish ??


all platforms
this sounds like stuff we don't need for beta; can we set this to M14 or M15?
Status: NEW → ASSIGNED
Target Milestone: M12
also new line break abd break below images...
also HTML tag in isert menu
I think the Format menu should have these changes:
 - change the order of Size and Style; 4.x is Font Face, Style, Size, Text Color
 - separator before Remove All Styles
 - add "Align" hierarchical menu
 - make "List" hierarchical
 - add Increase and Decrease Indent
 - selected item(s) properties
 - add Page Properties (when supported)
 - [What about Page Title?]

For the Edit menu:
 - add Preferences

For the File menu:
 - add "Send Page" if the browser is also supporting it.

Should the Table menu come before the Format menu?  I think that was the plan for
5.0 classic... (??)

Sujay--I don't think we are going to support New Page from Wizard or Template, at
least not any time soon (?).  Also, at this time we won't have Publish in the
menus or toolbars either.  Also, I don't think we are going to support "Edit HTML
Source" for the time being.  "Browse Page" is being supported by the tabs Charley
has at the bottom of the window.  View HTML Source is currently disabled.  Is
there a bug for this?  Could you please file it if not?

Insert HTML Tag is now called "Insert HTML Source" and the dialog it brings up
has changed slightly to accommodate multiple tag insertion.
Comments on Kathy's suggestions:
The order of the Format items in 4.x Windows is
Font, Size, Style, Color, Remove All Style, [sep]. So maybe Mac is different?
I don't care which order to use. Font, Style, Size sounds good to me.
We will have "Remove All Styles" and "Remove Link(s)", so these could go in
there own "group" (separators above and below)
The "List" menu is a new problem. In 4.6, the List submenu only allowed changing
the "type" of list (numbered, bulleted, etc) but not number or bullet styles.
Thus it was incomplete. We relied on the Paragraph Properties dialog to do that.
I thought of adding complete list attribute manipulation via menus, but given
that monitoring the state at the current selection for every detailed attribute
is risky (slows down caret movement), I thought it would be simplest to make
the item "List..." and have it bring up the List Properties dialog, which allows
you to change list type and number/bullet styles. Thus it is more like the
other property items on this menu that bring up property dialogs.
I think the "Table" menu should be just after Format - most like other programs.
I need to ask the mail folks if they had some concept to implement for the
"New" page items from templates or Wizard. If they don't, then we should drop
those for 5.0. Note: These need to be in an overlay XUL file to be shared.
Didn't Simone thing "Insert HTML Source" was to geeky (and suggested using
"tag")? Maybe we should use "Insert HTML tag(s)"?
add myself to cc list.

Sorry, I didn't realize Mac and Windows were different for the ordering in the
format menu.  I don't care about the order (was just trying to be consistent with
4.x).

I agree that the two "remove" items should be in their own group (separators).

I think we should stick to the 4.x functionality for the List menu.  I think we
can ship beta without the list properties dialog and no way for people to reset
their lists (except manually?).

As for the Table menu, I was thinking it might go better with "Insert" since
Inserting form elements (some day) would probably go right after "Insert" and
then the menubar would read something like: File Edit View Insert Forms Table
Format Tools ...
instead of:  File Edit View Insert Forms Format Table Tools ...
Do you envision a different menubar?

5.0 mail/news does have templates but they are stored in a mailbox format (as in
4.x)

Lastly, I think you're right that Simone suggested something else for "Insert
HTML Source"  Charley--Do you have your notes handy?
Depends on: 16118
Target Milestone: M12 → M14
moving this to M14
Blocks: 18471
Summary: missing menu items from ender → tracking bug for missing menu items from Composer
Target Milestone: M14 → M16
this is being used as a tracking bug for the inclusion of menu items within
Composer. As the features get implemented, the associated menu item will be
added. Setting this to m16. I also updated the Summary to better reflect the
purpose of the bug.
The "Page Source" item in the View menu has been removed until view source
is implemented correctly (see bug 6119).
Depends on: 6119
*** Bug 25124 has been marked as a duplicate of this bug. ***
Bug 22178 is direct dependency (implement View Source using current DOM). That
bug depends on or may be fixed if browser implements it in the same way (bug
6119).
Since "View | Page Source" is now working in the browser (but uses original URL,
not the current content), we could activate the menu item to do it the same
way until 22178 is finished. Should we do that?
Depends on: 22178
imo... I don't think we should enable the wrong version of "View Source"; it'd be 
way too confusing and possibly cause people to lose data.  I think we should 
leave the menu item out entirely until it is implemented correctly (even if it 
means we don't have View Source in 5.0).

I fully agree with kathy on this point: don't knowingly enable broken 
functionality.
However, I don't know whether our policy is to:
1)remove non-functioning menu items for beta
2)leave them in place but permanently disabled
3)enable the menu item, but have it pop up a "not enabled for beta" message.

I like (3) by far the best. It tells the user what we're planning to do, and 
leaves the basic UI intact for screen shots and such.  It also means we can 
write the enable/disable menu item command code and fully test it now, even if 
the actions backing the menu items aren't working fully.
I agree with Steve: option 3 sounds best.
Please review and compare to specs - I think we are very close now!
Page source is now implemented, so we don't need any messagebox.
Here's what I see needs fixing:

File Menu:
 Send Page (what about "Send Frame and Send Link")?
File>New:
 Missing "Instant Message" (Commercial build only)
File>Save As
 is missing! Don't know anything about this! Don't think we need it.
View:
 "Hide Extra Markup" is there now, but probably won't stay.
 Instead of the single "Character Set" item in the spec,
   we have 6 Charset submenus!
   The browser has a single "Character Coding" item and the submenus 
   we have are under that.
View>Toolbars:
 We will probably add an "Show/Hide Edit Modes" item
View>Sidebar 
  is missing. We now have just "View Sidebar" that is checked/unchecked.
  Missing item is "Customize My Panels..."

Edit Menu:
 Remove "Paste As Quotation"

Insert menu is OK!

Format:
 Change "Style" to "Text Style"
 Move "Align" item to be just after "List..."
 Change "List Properties..." to "List..."
 Fix accesskeys to agree with spec
  Add "Alt-Enter" as keybinding for Properties item
  Spec should mention about dynamic change to this item,
  it changes to appropriate selected object, like "Image Properties..."
  Object names are: Image, Link, Named Anchor, H.Line, Table, Table Cell, 
    or HTML Tag.

Format>Text Color and Format>Background Color
  will be changed to display the colorpicker popup.
  It will be located just as a menupopup would, but look just like
  the colorpicker popup in the toolbar, with the array of color swatches.
  It will have the bottom on the bottom to use "default" color, but not
  the caption that the toolbar version has.
Table:
 Items agree with spec, but there should be a "Split cell" item
 under "Join Cells"
  in both menu and spec. This isn't implemented yet.

 "Join Cells" is the proper text when > 1 cell is selected.
  If just 1 cell is selected, or caret is inside a cell, this item should say:
  "Join with cell to right" 
Rest of the menus are from global overlays and we don't change them.

Shouldn't we try to get menus finalized before Beta1?
These changes are all very safe text spelling changes or just moving a menu
item location.
Requesting PDT approval.
Keywords: beta1
Summary: tracking bug for missing menu items from Composer → Composer menu work - tracking bug for all menu items.
*** Bug 28242 has been marked as a duplicate of this bug. ***
*** Bug 28242 has been marked as a duplicate of this bug. ***
Changing to M14
Target Milestone: M16 → M14
PDT-
Whiteboard: [PDT-]
Here are some notes regarding Charley's comments on 2-17-2000:
 * definitely need File | Send Page; should hold off for now on the others until 
we think about these

 * I see File | Save As... in my menu in Composer; we definitely need this in 
Composer.  I'm not sure why you'd want to remove such basic / expected 
functionality.

 * View | Show/Hide Extra Markup should definitely stay in the menu (though these 
should be 1 menu item that toggles the two strings); since the tabs aren't 
obviously tabs, we should leave these in the menus so users will be more likely 
to discover this functionality.

 * the View | Character Set menu spec has changed; I think it is fine to have 6 
if that is what the i18n folks want

 * View | Sidebar should be consistent with Browser and Mail

i have implemented file->send page, i need someone to review and test it though 
it is posted at n.p.m.editor.
Moving to M15 since we don't seem to care about menus for Beta1.
Target Milestone: M14 → M15
Clearing beta1 and PDT- for work we know will be after beta1
Keywords: beta1
Whiteboard: [PDT-]
Concerning Kathy's notes on 2-18-00:
The "File -> Save As" that I said was missing is not the basic menuitem,
but the submenu as shown in the menu specs. It has "File" and "Template"
as items in that submenu. I was stating that I don't know if we need the 
submenu. Of course we need the "Save As" to file command.

Most of the work done, but some items remain for M16
Target Milestone: M15 → M16
updating keyword and status whiteboard to reflect that this is a beta 2 feature 
work bug that the Composer team deems a must fix for beta 2.
Severity: normal → major
Keywords: beta2
Priority: P3 → P1
Whiteboard: Composer feature work
Keywords: nsbeta2
*** Bug 36989 has been marked as a duplicate of this bug. ***
The menu option to edit HTML source needs to be added to the Edit menu.
Keywords: beta2
Please add recent pages menu item under File menu.  Also Revert?

Done.
[nsbeta2+ until 5/16]
Whiteboard: Composer feature work → [nsbeta2+ until 5/16] Composer feature work
I believe all of the menu items are now correct.
The spec still hasn't been updated to reflect newer decisions (many discussed
above), so this will be hard to verify.
Any menu changes should probably be filed as separate bugs now, so should we
mark this fixed now?
Beppe said it's ok to close this now.
Sujay: Since the spec isn't accurate, if you have any questions about the menus,
please email me.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
UE spec is updated and mostly matches product now.
http://gooey/client/5.0/specs/composer/Ender_Menus.html

May I suggest "Edit Mode Tabs" instead of "Edit Mode Toolbar"? (Or maybe Simone 
has a better term) Its not really a toolbar and all toolbars are in the Toolbar 
flyout anyway.

We agreed that Table/Insert would be first since it is used most often.

Format
Remove All Text  Styles --- Ctrl+Shift+K
Remove Link(s)
should be separated with horizontal lines from the rest of menu.

Print Setup. Shouldn't this be "Page Setup"?  Seems diff components are using 
different wording here?  As long as we all are consistent, either is fine with 
me.

Looking good!
Thanks for updating the specs.
The "Edit Mode" is a "toolbar" in that it has buttons, albeit they are "tabs",
and the collapse widget at the left edge. And it's logical to put the Show/Hide
functionality in the View | Toolbars submenu (status bar is also there)
I kinda like "EditModeBar" (tm)!
Any other opinions?
I forgot about Table "Insert" menu - done.
Added separator to Format menu - done.
Will checkin those soon.
We did use "Page Setup" in 4.x, but Navigatore is using "Print Setup" now,
so we are consitent. I don't care which either! Just as long as the dialog
that comes up also has the same name.
But the real problem is that this should be in globalOverlay, not in 
separate modules. I remember filing a bug on that a long time ago!
If you could track that down, I'd appreciate it.



I spoke with German about Print Setup vs Page Setup.  We will be using "Page 
Setup" since this is more common among apps, both Windows and Mac.  I'll try and 
find that bug, and if not, file a new one.  Thanks.
verified in 5/19 build.
Status: RESOLVED → VERIFIED
No longer blocks: 18471
You need to log in before you can comment on or make changes to this bug.