143543 - Mac OS 8.6: Can't save files, or save composer files

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Brad Tiffany]

Go to a web page, select File->Save Page As... and get nothing; the Save dialog
never appears.  Happens in composer as well.  Saw on 2002050703, but I went back
and checked a 4/25 build and it happens there too.  OS 8.5/8.6 only?

Comment 1

[Red Wolf]

wfm: build 2002041711 under Mac OS 9.1

Comment 2

[Simon Fraser [no longer active]]

Please test under OS 8.6. It may also matter whether File Sharing is turned on
or not.

Comment 3

[sairuh (rarely reading bugmail)]

in addition to not being able to save web pages (either by File > Save Page As,
or using the context menu item "save target link as"), i cannot export bookmarks
or save composer files.

i'm not sure if this is the correct component for these issues (or, if they're
unrelated), but reassign as needed.

i can reproduce these problems (using a lab machine) on Mac OS 8.6 (file sharing
is off) with both mozilla and commercial 2002.07.01.05-1.0 branch bits.

i didn't get any js console output with the commercial build (odd), but i did
when using mozilla:

a. after attempting to export bookmarks:

Error: uncaught exception: [Exception... "Component returned failure code:
0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]"  nsresult:
"0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://communicator/content/bookmarks/bookmarks.js :: fillViewMenu ::
line 117"  data: no]

b. after closing Composer (after failing to save):

Error: setting a property that has only a getter
Source File: chrome://editor/content/ComposerCommands.js
Line: 1868

i'm gonna turn on the pref for js errors in the chrome (fwiw), to see if i get
more info.

as it is, this is a blocker for users on Mac OS 8.6 --thus nominating since i
*think* we're supporting this platform. let me know if that support has changed!

Comment 4

[sairuh (rarely reading bugmail)]

hrm, didn't get any additional js console output when i set
user_pref("javascript.options.showInConsole", true); for the profile used with
the mozilla branch build.

Comment 5

[sairuh (rarely reading bugmail)]

note: i couldn't reproduce this on 9.1 or 10.1.5.

Comment 6

[timeless]

notes, 1. someone from netscape recently snuck 9.1 into the release notes as 
the minimum version. I've since undone that change for mozilla.org, Requiring 
9.1 is really mean, and I welcome someone from netscape to send me a CD 
containining 9.1, as it's impossible for me to upgrade from 9.0.4 w/o a CD. 
However I can't imagine netscape sending users 9.1 CD just so that they can use 
mozilla/netscape7.

2. a user came to #mozillazine and helped research this, we concluded that:
3. the pref error is unrelated. (actually i think *all* of the jsconsole 
outupt is unrelated)
4. It's really really disappointing that no JS Errors were thrown in these 
cases.
5. we weren't sure what to do about bookmarks see 4.

anyway, i'm asking some undermac friends if they have any insights.

Comment 7

[Steve Dagley]

Sorry.  According to Apple Mac OS 9 is dead.  That pretty much makes Mac OS 8.6
a rotted corpse.  I believe it's accurate to state that no Mac developer at
Netscape has a development machine even capable of running a version of Mac OS
prior to 9.  If some external contributor wants to keep plugging away on fixes
to keep 8.6 running that's fine, patches are gladly accepted.  At some point
even that's going to be futile though as there are definite plans to migrate the
Mac builds to mach-o and that runtime is _only_ for Mac OS X.

Comment 8

[timeless]

sigh, mine.

Comment 9

[timeless]

i'll try to figure out which of my machines will run 8.x and see if i can set a 
trap somewhere useful. tim, i don't suppose you could help shine some light on 
this?

Comment 10

[Simon Fraser [no longer active]]

What sdagley said. We can't keep supporting old OSes. People running these will
have machines which are borderline performance-wise for running Mozilla. OS 9 is
dead. OS 8.x is dead and buried. Move on.

Comment 11

[Bill Law]

Please note that this problem arises in all cases where we write out data files
on MacOS 8.6, not just when the browser does it (which is generally the area
covered by "File Handling").  I'm going to look to reassign to whoever owns
nsLocalFileMac   (which is where the problem likely resides).

Comment 12

[TimMaroney]

Hello timeless -- without a stack trace or some other kind of diagnostic info such as an assertion or debug log 
this is going to be hard to look at. I don't have anything less than 9.2 myself. This may well be something very 
simple, and an error/debug build would probably bring it to the top.

Without being quite as vehement as my esteemed colleagues, I am also not all that enthusiastic about 
helping out with the 8.6 project if there turn out to be a lot of problems there, although I'm available to help 
with Mac-specific problems that affect more people. I would prefer it if you would set up a Mac debug build 
yourself, with my and/or sfraser's help if necessary, so that you can get better debug info if problems like this 
come up on your configuration. With assertion failures, error codes, a stack trace, etc., it's often possible for me 
to find the problem by eyeballing the code, which I'm willing to do.

Comment 13

[benc]

timeless: whoever did that needs to be undone. For one thing, my understanding
is that our commercial products have shipped supporting 8.6. I might be wrong,
so if someone who works directly on Mac aspects needs to correct me, please do so.

I heard mozilla might even still be willing to support 8.5, it is just a matter
of the community maintaining interest as time goes on...

Comment 14

[Simon Fraser [no longer active]]

This is a nav services error, so -> sdagley. The nav services call to show the
Put File dialog is returning -5699, kNavMissingKindStringErr.

It seems that it wants the translation manager 'kind' resource, which might have
to sync up with the filters popup.

See
<http://developer.apple.com/techpubs/mac/MoreToolbox/MoreToolbox-429.html>

Comment 15

[Simon Fraser [no longer active]]

Note that this bug happens because of our abuse of the menuCreator/menuType
fields of the dialogOptions->popupExtension.

      (*dialogOptions->popupExtension)[index].menuCreator = OSType(index);
      (*dialogOptions->popupExtension)[index].menuType = OSType(index);

Comment 16

[scottputterman]

Steve, NS 7.0 currently supports 8.6.  It looks like Simon has narrowed this
down.  Could you take a look into this for RTM and give an estimate as to what
it would take to fix this?

Comment 17

[Steve Dagley]

Thanks to Simon for the investigative work since I have no hardware capable of
running anything prior to Mac OS 9.1.

Actually I believe the real culprit is
<http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsFilePicker.cpp#813>
which is used to ensure only the items we specify in the Format menu appear.

From the Apple Navigation Servives docs
<http://developer.apple.com/techpubs/macosx/Carbon/Files/NavigationServices/Prog_Navigation_Services/Enumerations/Generic_File_ure_Constant.html>:
>>>>>
To specify that your application can open all files of a given type (such as
'TEXT', for example), specify the kNavGenericSignature constant in the
componentSignature field of the structure of type NavTypeList that you pass to a
file-opening function such as NavGetFile. You can also pass this constant in the
fileCreator parameter of the function NavPutFile in order to override the types
of files appearing in the Format pop-up menu. For more information on using
NavTypeList structures, see “Providing File Opening Options”. This constant is
only available in Navigation Services 2.0 or later.
<<<<<

Mac OS 8.6 only implements Navigation Services 1.0 which is a big festering POS.
 To 'fix' this problem I can remove the support for the Format popup menu when
the user is running Mac OS 8.6.  Is that acceptable?

Comment 18

[Simon Fraser [no longer active]]

Yup. If I comment out
  creatorToSave = kNavGenericSignature;
it works (although the popup comes up showing a '-').

Comment 19

[Steve Dagley]

Attachment: Simple fix

Check version of Navigation Services and if it's less than 2.0 don't add the
Format menu to the file save dialog.  Emiminates functionality to pick what
format to save on 8.6 but that should be better than not being able to save
anything.

Comment 20

[Kathleen :Brade]

Comment on attachment 90724 [details] [diff] [review]
Simple fix

r=brade

Comment 21

[Paul Wyskoczka]

Can we get an sr= on this fix.

Comment 22

[scottputterman]

Who is the best person to sr= this?

Comment 23

[Steve Dagley]

Attachment: Fancier patch that _might_ work on 8.6

This patch might preserve the Format menu capability on Mac OS 8.6.  Untested
since I don't have a machine capable of running 8.6 but Simon has agreed to
test it on the machine he's borrowed.

Comment 24

[Kathleen :Brade]

Comment on attachment 91388 [details] [diff] [review]
Fancier patch that _might_ work on 8.6

assuming this works on 8.x, r=brade (I tested it with 9.x on trunk in browser)

Comment 25

[Paul Wyskoczka]

Hey Steve and Kathy, any change of getting the newest patch sr= soon so we can
get this fix checked into the trunk and tested.

Comment 26

[Simon Fraser [no longer active]]

With this patch on Mac OS 8.6, the save dialog comes up, and initially shows a
'-' as the current item in the format popup. If you save like this, you'll get
'web page complete'. Choosing to save in 'Web page complete' or 'text' format
both work correctly. In addition, next time you bring up the dialog, it
remembers the format. So I'd say that this patch is good.

Comment 27

[Simon Fraser [no longer active]]

Comment on attachment 91388 [details] [diff] [review]
Fancier patch that _might_ work on 8.6

sr=sfraser

Comment 28

[Steve Dagley]

Attachment: Fancy patch - take 2

This should account for the menu having a seperator item

Comment 29

[Simon Fraser [no longer active]]

Comment on attachment 91427 [details] [diff] [review]
Fancy patch - take 2

sr=sfraser. Even better, this patch doesn't cause the menu to come up with '-'
initially, and prevents you from choosing that.

Comment 30

[Asa Dotzler [:asa]]

Comment on attachment 91427 [details] [diff] [review]
Fancy patch - take 2

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

Comment 31

[Steve Dagley]

Thanks to sfraser's help with testing SWAG versions of patches the fix has been
landed on trunk.  Leaving open pending resolution on the branch.

Comment 32

[sairuh (rarely reading bugmail)]

resolving as fixed, since it went onto the trunk, and that's the ritual for such
things these days. ;) i'll test this tomorrow...

Comment 33

[sairuh (rarely reading bugmail)]

using 2002.07.16.08 trunk comm bits on OS 8.6 i was able to do the following:

a. saving via context menu
b. saving via toplevel menu/cmd+S: as text, html only, html complete (and it
remembered my last choice).
c. saving a composer file.

exporting bookmarks didn't quite work, but it's an improvement. i got as far as
selecting a target location (file picker) and it seem to accept the
name/location, but it wasn't saved.

since i got farther along on this feature than what was reported by users in
this bug, i filed a separate bug 157763... and will verify this one as fixed on
the TRUNK.

Comment 34

[Jaime Rodriguez, Jr.]

removing export bookmarks from the summary as that is now bug 151837.

Comment 35

[scottputterman]

marking adt1.0.1+. Please get drivers approval before checking into the branch.

Comment 36

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 37

[Steve Dagley]

fix landed on branch

Comment 38

[sairuh (rarely reading bugmail)]

vrfy'd fixed on the BRANCH using 2002.07.22.05-1.0 comm bits on OS 8.6.

Comment 39

[Greg K.]

*** Bug 145486 has been marked as a duplicate of this bug. ***

Comment 40

[Greg K.]

*** Bug 153894 has been marked as a duplicate of this bug. ***

Comment 41

[Boris Zbarsky [:bzbarsky]]

*** Bug 155385 has been marked as a duplicate of this bug. ***

Comment 42

[Greg K.]

*** Bug 151320 has been marked as a duplicate of this bug. ***