143560 - showdependencytree.cgi eats all available memory if there's a circular dependency

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Dave Miller [:justdave]]

showdependencytree.cgi eats all available memory if there's a circular dependency.

The kernel usually ends up killing the process.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

This patch fixes the problem by marking the bug currently being processed as
"seen" before it recurses into the next level of the hierarchy.

Comment 2

[Bradley Baetz (:bbaetz)]

Would it be better if the cgi just didn't generate the recusrive stuff to push
to the template in the first place?

ie move the second test on line 133 inside the first if statement?

Or would that be messier?

Comment 3

[Bradley Baetz (:bbaetz)]

*** Bug 143634 has been marked as a duplicate of this bug. ***

Comment 4

[Tobias Burnus]

Concerning the patch (attachment 83117 [details] [diff] [review]) see also bug 143634 comment 3.

Comment 5

[Gervase Markham [:gerv]]

I like Myk's fix. As far as I'm concerned, the data structure given to the
template reflects the reality of the database. Making it not do so in some way
(to avoid this problem) would be wrong.

Gerv

Comment 6

[Myk Melez [:myk] [@mykmelez]]

I'm having computer problems this weekend and can't check this in, so anyone is
welcome to check it in for me if it gets review before Monday.

Comment 7

[Gervase Markham [:gerv]]

Comment on attachment 83117 [details] [diff] [review]
patch v1: fixes problem

2xr=gerv.

Gerv

Comment 8

[Gervase Markham [:gerv]]

Fixed on trunk and branch.

Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v
 <--  dependency-tree.html.tmpl
new revision: 1.4.2.1; previous revision: 1.4
done

Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v
 <--  dependency-tree.html.tmpl
new revision: 1.5; previous revision: 1.4
done

Gerv